system-probe: use cgroup aware memory limit #16190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spikat
approved these changes
Mar 21, 2023
vboulineau
approved these changes
Mar 21, 2023
brycekahle
approved these changes
Mar 21, 2023
sgnn7
approved these changes
Mar 21, 2023
KSerrania
approved these changes
Mar 22, 2023
10 tasks
paulcacheux
added a commit
that referenced
this pull request
May 25, 2023
This reverts commit 34c60be.
paulcacheux
added a commit
that referenced
this pull request
May 26, 2023
This reverts commit 34c60be.
10 tasks
paulcacheux
added a commit
that referenced
this pull request
May 26, 2023
This reverts commit 34c60be.
paulcacheux
added a commit
that referenced
this pull request
May 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR is the system probe counter part of #14552, using the new
GOMEMLIMITsetting provided by go 1.19 to instruct the GC of the cgroup (container) memory limit.This PR also removes the memory controller which is what we used before (or did not use actually to be fair) to play the same role
For agent-platform: the license script fix is for https://github.com/open-policy-agent/opa/blob/main/internal/edittree/bitvector/license.txt. Because macOS filesystem is case insensitive it was working on macOS but failing in the CI (running on linux).
Motivation
Additional Notes
Possible Drawbacks / Trade-offs
Describe how to test/QA your changes
Reviewer's Checklist
Triagemilestone is set.major_changelabel if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.changelog/no-changeloglabel has been applied.qa/skip-qalabel is not applied.team/..label has been applied, indicating the team(s) that should QA this change.need-change/operatorandneed-change/helmlabels have been applied.k8s/<min-version>label, indicating the lowest Kubernetes version compatible with this feature.