Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[single-machine-performance] file_to_blackhole: change optimization goal to egress throughput #15631

Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions .gitlab/functional_test/regression_detector.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ single-machine-performance-regression_detector:
paths:
- submission_metadata
variables:
SMP_VERSION: 0.6.6-rc1
LADING_VERSION: 0.11.2
SMP_VERSION: 0.7.0
LADING_VERSION: 0.12.0
TOTAL_SAMPLES: 600
WARMUP_SECONDS: 45
REPLICAS: 10
Expand Down Expand Up @@ -63,7 +63,6 @@ single-machine-performance-regression_detector:
--comparison-sha ${CI_COMMIT_SHA}
--target-name datadog-agent
--target-command "/bin/entrypoint.sh"
--target-inherit-environment
--target-environment-variables "DD_HOSTNAME=smp-regression,DD_DD_URL=http://127.0.0.1:9092,DD_API_KEY=00000001"
--target-config-dir test/regression/
--target-cpu-allotment ${CPUS}
Expand Down
14 changes: 14 additions & 0 deletions test/regression/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,20 @@ The structure of each case is as follows:
* `datadog-agent/` -- __Required__ This is the configuration directory of your
program. Will be mounted read-only in the container build from `Dockerfile`
above at `/etc/datadog-agent`.
* `experiment.yaml` -- __Optional__ This file can be used to set a
single optimization goal for each experiment.

In this file, the optimization goal is set via a snippet like

```yaml
optimization_goal: ingress_throughput
```

Supported values of `optimization_goal` are `ingress_throughput` and
`egress_throughput`.

If an experiment omits this file, the optimization goal defaults to
`ingress_throughput`.

[Vector]: https://github.com/vectordotdev/vector/tree/master/regression
[lading]: https://github.com/DataDog/lading
1 change: 1 addition & 0 deletions test/regression/cases/file_to_blackhole/experiment.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
optimization_goal: egress_throughput