Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport #15399: flare: Do not scrub pprof files #15402

Merged
merged 1 commit into from
Feb 2, 2023

Conversation

L3n41c
Copy link
Member

@L3n41c L3n41c commented Feb 2, 2023

What does this PR do?

Backport #15399

Fix the pprof profile collection with agent flare --profile.

Motivation

pprof profiles are currently corrupted by the flare scrubber.

Additional Notes

This fixes a regression introduced in #14234.

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Generate a flare with pprof profiles with agent flare --profile 60.

The pprof files should now be readable by go tool pprof.
Before this fix (check with 7.43.0-rc.3 if you want to compare), go tool pprof was failing with this error:

$ go tool pprof -raw lenaic-agent-dev_lhuard_fr-7.43.0-rc.3/profiles/core-cpu.pprof | head
lenaic-agent-dev_lhuard_fr-7.43.0-rc.3/profiles/core-cpu.pprof: decompressing profile: flate: corrupt input before offset 566
failed to fetch any source profiles

Reviewer's Checklist

  • If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
  • Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
  • A release note has been added or the changelog/no-changelog label has been applied.
  • Changed code has automated tests for its functionality.
  • Adequate QA/testing plan information is provided if the qa/skip-qa label is not applied.
  • At least one team/.. label has been applied, indicating the team(s) that should QA this change.
  • If applicable, docs team has been notified or an issue has been opened on the documentation repo.
  • If applicable, the need-change/operator and need-change/helm labels have been applied.
  • If applicable, the k8s/<min-version> label, indicating the lowest Kubernetes version compatible with this feature.
  • If applicable, the config template has been updated.

@L3n41c L3n41c added this to the 7.43.0 milestone Feb 2, 2023
@L3n41c L3n41c requested a review from a team as a code owner February 2, 2023 16:35
@L3n41c L3n41c force-pushed the lenaic/backport_15399 branch from 17dce24 to e9feff3 Compare February 2, 2023 17:55
@L3n41c L3n41c merged commit 17eb73d into 7.43.x Feb 2, 2023
@L3n41c L3n41c deleted the lenaic/backport_15399 branch February 2, 2023 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants