Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RCM] Allow querying of APM_TRACING remote configs on demand #15054

Closed
wants to merge 1 commit into from

Conversation

ameske
Copy link
Contributor

@ameske ameske commented Jan 12, 2023

Allows users of the remote config client to get the current state of APM_TRACING configs on-demand outside of the normal on update event loop.

What does this PR do?

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Reviewer's Checklist

  • If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
  • Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
  • A release note has been added or the changelog/no-changelog label has been applied.
  • Changed code has automated tests for its functionality.
  • Adequate QA/testing plan information is provided if the qa/skip-qa label is not applied.
  • At least one team/.. label has been applied, indicating the team(s) that should QA this change.
  • If applicable, docs team has been notified or an issue has been opened on the documentation repo.
  • If applicable, the need-change/operator and need-change/helm labels have been applied.
  • If applicable, the k8s/<min-version> label, indicating the lowest Kubernetes version compatible with this feature.
  • If applicable, the config template has been updated.

Allows users of the remote config client to get the current state of
APM_TRACING configs on-demand outside of the normal on update event
loop.
@ameske ameske added this to the 7.43.0 milestone Jan 12, 2023
@ameske ameske requested a review from a team as a code owner January 12, 2023 20:04
Copy link
Contributor

@ahmed-mez ahmed-mez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ameske
Copy link
Contributor Author

ameske commented Jan 13, 2023

Closing in favor of #15062

@ameske ameske closed this Jan 13, 2023
@dd-devflow dd-devflow bot deleted the kyle.ames/rcm-config-retrieval-on-demand branch April 19, 2024 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants