-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rename configMissingOK field to baseConfigMissingOK #14855
Closed
modernplumbing
wants to merge
1
commit into
celia.yuen/setupConfig-signature
from
celia.yuen/rename-ConfigMissingOK
Closed
rename configMissingOK field to baseConfigMissingOK #14855
modernplumbing
wants to merge
1
commit into
celia.yuen/setupConfig-signature
from
celia.yuen/rename-ConfigMissingOK
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 26, 2022
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
10 tasks
9fcc695
to
2b292f3
Compare
43a3cfe
to
42a8148
Compare
2b292f3
to
8aca208
Compare
10 tasks
c8b6edd
to
9336915
Compare
8aca208
to
efb5ee1
Compare
9336915
to
303af9f
Compare
efb5ee1
to
21b89cb
Compare
Merged
10 tasks
21b89cb
to
bd27a22
Compare
303af9f
to
feeaab0
Compare
bd27a22
to
b5ffc2f
Compare
feeaab0
to
b4b3070
Compare
b5ffc2f
to
80fb399
Compare
8420168
to
a2bb920
Compare
80fb399
to
7952210
Compare
merged into #14884 |
10 tasks
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
changelog/no-changelog
[deprecated] qa/skip-qa - use other qa/ labels
[DEPRECATED] Please use qa/done or qa/no-code-change to skip creating a QA card
team/agent-security
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Motivation
Additional Notes
Possible Drawbacks / Trade-offs
Describe how to test/QA your changes
Reviewer's Checklist
Triage
milestone is set.major_change
label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.changelog/no-changelog
label has been applied.qa/skip-qa
label is not applied.team/..
label has been applied, indicating the team(s) that should QA this change.need-change/operator
andneed-change/helm
labels have been applied.k8s/<min-version>
label, indicating the lowest Kubernetes version compatible with this feature.