Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename configMissingOK field to baseConfigMissingOK #14855

Conversation

modernplumbing
Copy link
Contributor

What does this PR do?

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Reviewer's Checklist

  • If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
  • Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
  • A release note has been added or the changelog/no-changelog label has been applied.
  • Changed code has automated tests for its functionality.
  • Adequate QA/testing plan information is provided if the qa/skip-qa label is not applied.
  • At least one team/.. label has been applied, indicating the team(s) that should QA this change.
  • If applicable, docs team has been notified or an issue has been opened on the documentation repo.
  • If applicable, the need-change/operator and need-change/helm labels have been applied.
  • If applicable, the k8s/<min-version> label, indicating the lowest Kubernetes version compatible with this feature.
  • If applicable, the config template has been updated.

@modernplumbing modernplumbing force-pushed the celia.yuen/rename-ConfigMissingOK branch from 9fcc695 to 2b292f3 Compare December 26, 2022 18:48
@modernplumbing modernplumbing force-pushed the celia.yuen/set-config-type-secagent-merge branch from 43a3cfe to 42a8148 Compare December 26, 2022 19:09
@modernplumbing modernplumbing changed the base branch from celia.yuen/set-config-type-secagent-merge to celia.yuen/exit-secagent-if-no-api-key December 26, 2022 19:20
@modernplumbing modernplumbing force-pushed the celia.yuen/rename-ConfigMissingOK branch from 2b292f3 to 8aca208 Compare December 26, 2022 19:20
@modernplumbing modernplumbing added changelog/no-changelog [deprecated] qa/skip-qa - use other qa/ labels [DEPRECATED] Please use qa/done or qa/no-code-change to skip creating a QA card team/agent-security labels Dec 26, 2022
@modernplumbing modernplumbing added this to the Triage milestone Dec 26, 2022
@modernplumbing modernplumbing force-pushed the celia.yuen/exit-secagent-if-no-api-key branch from c8b6edd to 9336915 Compare December 27, 2022 18:23
@modernplumbing modernplumbing force-pushed the celia.yuen/rename-ConfigMissingOK branch from 8aca208 to efb5ee1 Compare December 27, 2022 18:23
@modernplumbing modernplumbing force-pushed the celia.yuen/exit-secagent-if-no-api-key branch from 9336915 to 303af9f Compare December 28, 2022 22:37
@modernplumbing modernplumbing force-pushed the celia.yuen/rename-ConfigMissingOK branch from efb5ee1 to 21b89cb Compare December 28, 2022 22:37
@modernplumbing modernplumbing force-pushed the celia.yuen/rename-ConfigMissingOK branch from 21b89cb to bd27a22 Compare December 28, 2022 23:00
@modernplumbing modernplumbing force-pushed the celia.yuen/exit-secagent-if-no-api-key branch from 303af9f to feeaab0 Compare December 28, 2022 23:58
@modernplumbing modernplumbing force-pushed the celia.yuen/rename-ConfigMissingOK branch from bd27a22 to b5ffc2f Compare December 28, 2022 23:58
@modernplumbing modernplumbing force-pushed the celia.yuen/exit-secagent-if-no-api-key branch from feeaab0 to b4b3070 Compare December 29, 2022 00:49
@modernplumbing modernplumbing changed the base branch from celia.yuen/exit-secagent-if-no-api-key to celia.yuen/setupConfig-signature December 29, 2022 00:49
@modernplumbing modernplumbing force-pushed the celia.yuen/rename-ConfigMissingOK branch from b5ffc2f to 80fb399 Compare December 29, 2022 00:49
@modernplumbing modernplumbing force-pushed the celia.yuen/setupConfig-signature branch from 8420168 to a2bb920 Compare December 29, 2022 12:26
@modernplumbing modernplumbing force-pushed the celia.yuen/rename-ConfigMissingOK branch from 80fb399 to 7952210 Compare December 29, 2022 12:26
@modernplumbing
Copy link
Contributor Author

merged into #14884

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog [deprecated] qa/skip-qa - use other qa/ labels [DEPRECATED] Please use qa/done or qa/no-code-change to skip creating a QA card team/agent-security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant