Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[workloadmeta] Add ContainerImageMetadata Kind #14535

Merged
merged 1 commit into from
Dec 5, 2022

Conversation

davidor
Copy link
Member

@davidor davidor commented Nov 30, 2022

What does this PR do?

Adds a new Kind to the workloadmeta store: ContainerImageMetadata.

The workloadmeta collectors will be adapted to extract container image metadata and will store them in workloadmeta, but that will come in future PRs.

Describe how to test/QA your changes

Nothing for now. We will test the changes in the workloadmeta collectors that will come in future PRs.

Reviewer's Checklist

  • If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
  • Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
  • A release note has been added or the changelog/no-changelog label has been applied.
  • Changed code has automated tests for its functionality.
  • Adequate QA/testing plan information is provided if the qa/skip-qa label is not applied.
  • At least one team/.. label has been applied, indicating the team(s) that should QA this change.
  • If applicable, docs team has been notified or an issue has been opened on the documentation repo.
  • If applicable, the need-change/operator and need-change/helm labels have been applied.
  • If applicable, the k8s/<min-version> label, indicating the lowest Kubernetes version compatible with this feature.
  • If applicable, the config template has been updated.

@davidor davidor added team/containers changelog/no-changelog [deprecated] qa/skip-qa - use other qa/ labels [DEPRECATED] Please use qa/done or qa/no-code-change to skip creating a QA card labels Nov 30, 2022
@davidor davidor added this to the 7.42.0 milestone Nov 30, 2022
@davidor davidor requested a review from a team as a code owner November 30, 2022 11:34
KindContainer Kind = "container"
KindKubernetesPod Kind = "kubernetes_pod"
KindECSTask Kind = "ecs_task"
KindContainerImageMetadata Kind = "container_image_metadata"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we can name the kind container_image
because we are only in workloadmetadata, so "metadata" is a bit redundant.
WDYT?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ContainerImage struct already exists. It's the one that we use to attach basic image info to containers:

type ContainerImage struct {

@davidor davidor force-pushed the davidor/workloadmeta-cont-image-metadata branch 2 times, most recently from c1881cf to 7ebbe14 Compare December 1, 2022 16:36
@davidor davidor force-pushed the davidor/workloadmeta-cont-image-metadata branch from 7ebbe14 to a1e9812 Compare December 1, 2022 18:43
@davidor davidor merged commit 73ef8f4 into main Dec 5, 2022
@davidor davidor deleted the davidor/workloadmeta-cont-image-metadata branch December 5, 2022 12:13
@L3n41c L3n41c mentioned this pull request Dec 8, 2022
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog [deprecated] qa/skip-qa - use other qa/ labels [DEPRECATED] Please use qa/done or qa/no-code-change to skip creating a QA card team/containers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants