usm: classification: Shrink classification buffer to 24 bytes (#14925)

DataDog · Jan 3, 2023 · 76da3cb · 76da3cb
1 parent ef5563b
commit 76da3cb
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 7 deletions.
diff --git a/pkg/ebpf/bytecode/runtime/conntrack.go b/pkg/ebpf/bytecode/runtime/conntrack.go
diff --git a/pkg/ebpf/bytecode/runtime/http.go b/pkg/ebpf/bytecode/runtime/http.go
diff --git a/pkg/ebpf/bytecode/runtime/tracer.go b/pkg/ebpf/bytecode/runtime/tracer.go
diff --git a/pkg/network/ebpf/c/protocols/protocol-classification-defs.h b/pkg/network/ebpf/c/protocols/protocol-classification-defs.h
@@ -6,10 +6,9 @@
 #include "amqp-defs.h"
 #include "mongo-defs.h"
 
-// Represents the max buffer size required to classify protocols .
-// We need to round it to be multiplication of 16 since we are reading blocks of 16 bytes in read_into_buffer_skb_all_kernels.
-// ATM, it is HTTP2_MARKER_SIZE + 8 bytes for padding,
-#define CLASSIFICATION_MAX_BUFFER (HTTP2_MARKER_SIZE + 8)
+// Represents the max buffer size required to classify protocols.
+// ATM, it is HTTP2_MARKER_SIZE.
+#define CLASSIFICATION_MAX_BUFFER (HTTP2_MARKER_SIZE)
 
 // Checkout https://datatracker.ietf.org/doc/html/rfc7540 under "HTTP/2 Connection Preface" section
 #define HTTP2_MARKER_SIZE 24