-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use proxy for caching Pypi dependencies #128
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, but we can't verify the omnibus build behavior in the test build done here until DataDog/datadog-agent#14473 is merged (because this repository uses main
of datadog-agent
to do its test runs). I suggest we merge the datadog-agent PR first, then redo a test build here, and check that the PIP_CONFIG_FILE
env variable is properly set in the omnibus environment for the relevant commands.
Agreed ! Will wait for #14473 to be merged ! |
So it seems to be working (see here) !
The thing is though that for each requirement in https://raw.githubusercontent.com/DataDog/datadog-agent-buildimages/main/requirements.txt, the requirement is already satisfied because of the Since the Pypi caching is working for |
I still have a question though, I looked into the other builds in I'm just wondering about the
Does that mean that the cache won't get updated until the |
Discussed offline, but for context:
That is correct, as the goal is to only redo the builder setup when the setup script is modified (because that setup takes 30 minutes). One other way to force the cache to be rebuilt is to change some other part of the cache key, like:
|
What does this PR do?
Implements usage of caching proxy for Pypi dependencies.
Same as #105 but for Python dependencies.
Motivation
Additional Notes
Possible Drawbacks / Trade-offs
Describe how to test/QA your changes
Reviewer's Checklist