This repository was archived by the owner on Apr 3, 2026. It is now read-only.
fix: allow system tests to override API Security sampling interval#44
Merged
RomainMuller merged 2 commits intomainfrom Apr 3, 2025
Merged
Conversation
Some system tests must override the sampling interval to 0 in order to be able to test schema extraction works as intended. This requires reading the default interval from an environment variable.
RamyElkest
approved these changes
Apr 3, 2025
| // | ||
| // Note: timestamps are stored at second resolution, so the interval will be | ||
| // rounded down to the nearest second. | ||
| func NewSet(interval time.Duration, clock ClockFunc) *LRU { |
Contributor
There was a problem hiding this comment.
side comment: function name is a little confusing after the renaming
Contributor
Author
There was a problem hiding this comment.
Good catch! I just don't see the name anymore at this point -_-
RomainMuller
deleted the
romain.marcadier/APPSEC-56547/api-sec-sampling-v2
branch
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some system tests must override the sampling interval to 0 in order to
be able to test schema extraction works as intended. This requires
reading the default interval from an environment variable.