Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PF-1922] Apply Formatting to repo: terra-cli #301

Merged
merged 4 commits into from
Aug 17, 2022
Merged

Conversation

dexamundsen
Copy link
Contributor

@dexamundsen dexamundsen commented Aug 17, 2022

Apply formatting to entire repo (no manual changes)

@dexamundsen dexamundsen changed the title Apply Format [PF-1922] Apply Formatting to repo: terra-cli Aug 17, 2022
@ddietterich ddietterich removed their request for review August 17, 2022 18:27
@yuhuyoyo
Copy link
Contributor

Could you kindly figure out why the lint check is not working?

@mikenev
Copy link
Contributor

mikenev commented Aug 17, 2022

What's driving this change? We do have spotless and the lint check, was it not applying rules or something?

@dexamundsen
Copy link
Contributor Author

@mikenev - looks like the google java format was not applied on the IDE. I applied this as part of JDK upgrade and lead to a whole lot of format changes. Hence split it to a separate PR
@yuhuyoyo - Fixed the check. There is an issue with single line comments: the rules for google java format and spotless check were conflicting

@dexamundsen dexamundsen marked this pull request as ready for review August 17, 2022 18:47
Copy link
Contributor

@mikenev mikenev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, that makes sense. Thanks for doing this in a separate review.

Copy link
Contributor

@yuhuyoyo yuhuyoyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is impossible to review so i will just trust you :)

@yuhuyoyo
Copy link
Contributor

yuhuyoyo commented Aug 17, 2022

filed https://broadworkbench.atlassian.net/browse/PF-1924 for better process.

@dexamundsen dexamundsen merged commit 538c920 into main Aug 17, 2022
@dexamundsen dexamundsen deleted the dexamundsen/format branch August 17, 2022 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants