Fix: Subgraph stitching query crashes BQ emulator (#5847) #5862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #5862 +/- ##
===========================================
+ Coverage 83.10% 83.15% +0.05%
===========================================
Files 154 154
Lines 19634 19636 +2
===========================================
+ Hits 16316 16329 +13
+ Misses 3318 3307 -11 ☔ View full report in Codecov by Sentry. |
hannes-ucsc
force-pushed
the
issues/hannes-ucsc/5847-bq-emulator-crash
branch
from
b57add0
to
0a5be74
Compare
hannes-ucsc
added
the
upgrade
hannes-ucsc
force-pushed
the
issues/hannes-ucsc/5847-bq-emulator-crash
branch
from
0a5be74
to
31db973
Compare
14 tasks
dsotirho-ucsc
force-pushed
the
issues/hannes-ucsc/5847-bq-emulator-crash
branch
from
31db973
to
1c61f88
Compare
dsotirho-ucsc
approved these changes
Jan 24, 2024
dsotirho-ucsc
added
the
sandbox
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connected issues: #5847
Checklist
Author
developissues/<GitHub handle of author>/<issue#>-<slug>Author (partiality)
ptag to titles of partial commitspartiallabel to PR or this PR completely resolves all connected issuespartiallabel1 when the issue title describes a problem, the corresponding PR
title is
Fix:followed by the issue titleAuthor (reindex, API changes)
rtag to commit title or this PR does not require reindexingreindexlabel to PR or this PR does not require reindexingAPIor this PR does not modify a REST APIa(A) tag to commit title for backwards (in)compatible changes or this PR does not modify a REST APIapp.pyor this PR does not modify a REST APIAuthor (chains)
baselabel to the blocking PR or this PR is not chained to another PRchainedlabel to this PR or this PR is not chained to another PRAuthor (upgrading deployments)
utag to commit title or this PR does not require upgrading deploymentsupgradelabel to PR or this PR does not require upgrading deploymentsAuthor (operator tasks)
Author (hotfixes)
Ftag to main commit title or this PR does not include permanent fix for a temporary hotfixprodbranch has no temporary hotfixes for any connected issuesAuthor (before every review)
develop, squashed old fixupsmake requirements_updateor this PR does not touch requirements*.txt, common.mk, Makefile and DockerfileRtag to commit title or this PR does not touch requirements*.txtreqslabel to PR or this PR does not touch requirements*.txtmake integration_testpasses in personal deployment or this PR does not touch functionality that could break the ITPeer reviewer (after requesting changes)
Uncheck the Author (before every review) checklists.
Peer reviewer (after approval)
System administrator (after requesting changes)
Uncheck the before every review checklists. Update the
N reviewslabel.System administrator (after approval)
demoorno demono demono sandboxN reviewslabel is accurateOperator (before pushing merge the commit)
reindexlabel andrcommit title tagno demoupgradedevelopdev.sharedand ranCI_COMMIT_REF_NAME=develop make -C terraform/shared apply_keep_unusedor this PR does not change any Docker image versionsanvildev.sharedand ranCI_COMMIT_REF_NAME=develop make -C terraform/shared apply_keep_unusedor this PR does not change any Docker image versionsanvilprod.sharedand ranCI_COMMIT_REF_NAME=develop make -C terraform/shared apply_keep_unusedor this PR does not change any Docker image versionssandboxlabel or PR is labeledno sandboxdevor PR is labeledno sandboxanvildevor PR is labeledno sandboxanvilprodor PR is labeledno sandboxsandboxdeployment or PR is labeledno sandboxanvilboxdeployment or PR is labeledno sandboxhammerboxdeployment or PR is labeledno sandboxsandboxdeployment or PR is labeledno sandboxanvilboxdeployment or PR is labeledno sandboxhammerboxdeployment or PR is labeledno sandboxsandboxor this PR does not remove catalogs or otherwise causes unreferenced indices indevanvilboxor this PR does not remove catalogs or otherwise causes unreferenced indices inanvildevhammerboxor this PR does not remove catalogs or otherwise causes unreferenced indices inanvilprodsandboxor this PR does not require reindexingdevanvilboxor this PR does not require reindexinganvildevhammerboxor this PR does not require reindexinganvilprodsandboxor this PR does not require reindexingdevanvilboxor this PR does not require reindexinganvildevhammerboxor this PR does not require reindexinganvilprodpif the PR is labeledpartialOperator (chain shortening)
developor this PR is not labeledbasechainedlabel from the blocked PR or this PR is not labeledbasebasebaselabel from this PR or this PR is not labeledbaseOperator (after pushing the merge commit)
devor PR is labeledno sandboxanvildevor PR is labeledno sandboxanvilprodor PR is labeledno sandboxdev1dev1anvildev1anvildev1anvilprod1anvilprod1dev.sharedand ranmake -C terraform/shared applyor this PR does not change any Docker image versionsanvildev.sharedand ranmake -C terraform/shared applyor this PR does not change any Docker image versionsanvilprod.sharedand ranmake -C terraform/shared applyor this PR does not change any Docker image versionsdevanvildevanvilprod1 When pushing the merge commit is skipped due to the PR being
labelled
no sandbox, the next build triggered by a PR whose merge commit ispushed determines this checklist item.
Operator (reindex)
devor this PR does not remove catalogs or otherwise causes unreferenced indices indevanvildevor this PR does not remove catalogs or otherwise causes unreferenced indices inanvildevanvilprodor this PR does not remove catalogs or otherwise causes unreferenced indices inanvilproddevor this PR does not merely remove sources from existing catalogs indevanvildevor this PR does not merely remove sources from existing catalogs inanvildevanvilprodor this PR does not merely remove sources from existing catalogs inanvilproddevor this PR does not merely add sources to existing catalogs indevanvildevor this PR does not merely add sources to existing catalogs inanvildevanvilprodor this PR does not merely add sources to existing catalogs inanvilproddevor this PR does not require reindexingdevanvildevor this PR does not require reindexinganvildevanvilprodor this PR does not require reindexinganvilproddevor this PR does not require reindexingdevanvildevor this PR does not require reindexinganvildevanvilprodor this PR does not require reindexinganvilproddevdeployment or this PR does not require reindexingdevanvildevdeployment or this PR does not require reindexinganvildevanvilproddeployment or this PR does not require reindexinganvilprodOperator
shared.prodShorthand for review comments
Lline is too longWline wrapping is wrongQbad quotesFother formatting problem