Automatic FUM update starts on every TTY

[m-iwanicki]

Component

Dasharo Tools Suite

Device

QEMU Q35 Emulator

Dasharo version

v0.2.1-rc1

Dasharo Tools Suite version

v2.6.0

Test case ID

No response

Brief summary

Automatic update done when DTS is booted via FUM starts on every tty which starts dts-boot

How reproducible

100%

How to reproduce

Start DTS via FUM on platform with serial (ttyS0) and other tty e.g. tty1 (probably most platforms).

Expected behavior

Only one update workflow running, possibly mirrored to all tty

Actual behavior

Multiple, separate update workflows

Screenshots

QEMU example, update tries to run on both tty1 and ttyS0

Additional context

This might result in hard to debug or reproduce bugs (e.g. race conditions) that result from workflows using the same files, accessing flash at the same time, e.t.c.

Solutions you've tried

No response

[DaniilKl]

A good catch. We need several TTYs available, but we do not want any race conditions or asynchronous writes/reads in DTS. We should consider fixing this.

[m-iwanicki]

Fixing this issue should also resolve #1613

[m-iwanicki]

Fix for this issue is fairly simple: ask user if he wants to continue with unattended update or enter DTS menu:

Choosing 1 will result in update starting the same as previosuly, while choosing 9 will result in entering DTS menu, the same as when booting DTS without FUM.

ttyS0 is still waiting for user input even after we entered shell in tty1: