Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix parsing of numPps in avcC box in mp4.js #6

Merged
merged 1 commit into from
Mar 23, 2018
Merged

Fix parsing of numPps in avcC box in mp4.js #6

merged 1 commit into from
Mar 23, 2018
+2 −3

Conversation

hallmarker
Copy link

No description provided.

@TobbeEdgeware TobbeEdgeware self-requested a review March 23, 2018 07:56
@TobbeEdgeware
Copy link

Seems like a copy-paste error. PPS counter has 8 bits vs SPS counter's 5 bits, so it looks correct. 👍

@TobbeEdgeware TobbeEdgeware removed their request for review March 23, 2018 07:56
@hallmarker
Copy link
Author

Yes it was a copy-paste error =)

@TobbeEdgeware TobbeEdgeware merged commit 5a592a0 into master Mar 23, 2018
@TobbeEdgeware TobbeEdgeware deleted the parse-numPps-correct-in-mp4-js branch March 23, 2018 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hallmarker @TobbeEdgeware