-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/unsupported security levels #4562
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ortedSecurityLevels
…ationSets with unusable key ids in the Controlbar
…ortedSecurityLevels
…ed immediately to avoid inconsistency with the ABR selection. Also reset BOLA utility values when a track is changed.
…or multiperiod streams
…r exception in Stream.js
…ortedSecurityLevels # Conflicts: # src/streaming/utils/Capabilities.js
…ortedSecurityLevels # Conflicts: # src/streaming/utils/Capabilities.js # test/functional/adapter/DashJsAdapter.js # test/functional/config/karma.functional.conf.cjs # test/unit/mocks/CapabilitiesMock.js
…ortedSecurityLevels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds various features around DRM related functionality, period transitioning and track/quality changes:
Features
keystatuseschange
events. If a key is not usable (internal-error
oroutput-restricted
) the player switches to a different track. In case of AdaptationSet Switching (urn:mpeg:dash:adaptation-set-switching:2016
) the unsupported Representations are removed from the list of possible options. Note: We are not automatically switching back to the previous track if a key becomes usable again. Addresses Handling of unsupported DRM security levels #4313changeType()
if the codec family has not changed. For instance, if we are switching betweenavc1
andavc3
we dont need to callchangeType()
. This fixes Win10Edge HEVC multiperiod test gives "error: creating source buffer of type: audio" #4304Improvements
once
to theEventBus
to listen only once for a certain eventexcludedPlatforms
attribute to functional test configuration to exclude platforms for specific tests e.g. not running a DRM Widevine/Playready test on SafariStreamProcessor
andBufferController
. Includes running operations in parallel and not waiting for promises to resolve.Fixes
changeType
Known Limitations