-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/v5 adaptation set switching #4276
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nSetSwitching # Conflicts: # src/dash/DashAdapter.js # src/dash/vo/MediaInfo.js # test/unit/streaming.StreamProcessor.js # test/unit/streaming.controllers.BufferController.js
…n transitioning to a new period
…nSetSwitching # Conflicts: # src/streaming/models/CmcdModel.js
This was referenced Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the SupplementalProperty
urn:mpeg:adaptation-set-switching:2016
. It implements the feature request described in #3908. For that reason, the main ABR handling in dash.js was changed to use Representation IDs instead of an index based approach.Representation@id
is a mandatory field and is unique within a period. The main changes of this PR includeMain changes
getBitrateInfoListFor
and instead return available representations inMediaPlayer. getRepresentationsByType
getSwitchRequest
instead ofgetMaxIndex
MediaInfo.adaptationSetSwitchingCompatibleIds
DashConstants
directly instead of using aclass
syntaxRepresentationController
RepresentationInfo
and add missing fields toRepresentation
MediaPlayer
now exposed functionsgetCurrentRepresentationForType
,setRepresentationForTypeById
,setRepresentationForTypeByIndex
Representation
class inStream
,StreamProcessor
StreamProcessor. selectMediaInfo
to distinguish between switching to a new AS as part of a quality switch or after manual selectionAbrController
now works withRepresentation
instances instead ofBitrateList
MediaController
filtersAdaptationSets
by possible bitrates and the portal size to start with a correct quality based on the settingsLimitations / Follow ups