Fix/buffer prune range #4056
Merged
Fix/buffer prune range #4056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
eastkiki
pushed a commit
to eastkiki/dash.js
that referenced
this pull request
Oct 4, 2022
* Fix pruning range ahead. Start should not exceed the end of the last range * When pruning ahead after a seek check for continuous buffer up to the buffer to keep ahead. * Fix missing endOfBuffer
bbert
pushed a commit
to Orange-OpenSource/dash.js
that referenced
this pull request
Oct 10, 2022
* Fix pruning range ahead. Start should not exceed the end of the last range * When pruning ahead after a seek check for continuous buffer up to the buffer to keep ahead. * Fix missing endOfBuffer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the logic for pruning the buffer ahead. Calculate the continuous buffer starting at the target time and prune according to the threshold values defined in the settings. Fixes #4055