-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix url anchor time #3453
Fix url anchor time #3453
Conversation
Before going ahead we need to agree on specs and use cases.
For dynamic streams:
|
My thoughts + relevant part of the MPEG spec:
|
OK, but while thinking to use cases, that would be more relevant to consider #t as the absolute time from 0.
But you don't know more about AST than period start time at application level. |
But this should also be possible if Period@start is greater than zero. I simply save the current playback position and add that as an offset to the start. If we use Period@start as an anchor this also covers the case in which period@start is 0.
Not sure I agree on this. The AST does not change, but periods disappear over time. There might even be outdated periods in the MPD. Or a period is removed by the time the application is initializing the player. However, the spec clearly states that the first/earliest period should be used if no period attribute is specified in the MPD anchor: Period: Value of a Period parameter Period@id. If period parameter is not present, the default value of the @id attribute value of the Period with the earliest PeriodStart. So I think we should stick to the behavior you described. |
This PR is fixing anchor time management in case of multiple periods
Anchor time shall be relative to 1st period but currently anchor time is computed as being relative to targeted (from anchor time) period start time