Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMCD update #3420

Merged
merged 12 commits into from
Oct 7, 2020
Merged

CMCD update #3420

merged 12 commits into from
Oct 7, 2020

Conversation

FritzHeiden
Copy link
Contributor

@FritzHeiden FritzHeiden commented Oct 5, 2020 •
edited
Loading

Updating the CMCD implementation to the current specification.

  • changed query key from 'Common-Media-Client-Data' to 'CMCD'
  • omitting '=true' in query string for boolean parameters
  • enclosing string values in double quotes, except tokens
  • sorting CMCD metrics alphabetically by key name
  • URL encoding CMCD metrics
  • added new metrics:
    • bl (Buffer length)
    • bs (Buffer starvation)
    • su (Startup)
    • tb (Top bitrate)
    • pr (Playback rate)
  • removed former metrics:
    • bs (Buffer size)
    • did (Device ID)
  • rounding values of metrics:
    • dl (Deadline)
    • mtp (Measured throughput)
  • added object type:
    • o (other)
  • omitting CMCD version if it is 1
  • extended CMCD sample
  • implemented unit tests for CMCD logic

resolves #3402

@FritzHeiden
Updated CMCD feature according to new CMCD spec
a4975ab 
- changed query key from 'Common-Media-Client-Data' to 'CMCD'
- omitting '=true' in query string for boolean parameters
- enclosing string values in double quotes, except tokens
- sorting CMCD metrics alphabetically by key name
- URL encoding CMCD metrics
- added new metrics: bl, bs, su, tb
- removed former metric: bs, did
- rounding metric values for dl and mtp
- added object type: o
- omitting CMCD version if it is 1
- extended CMCD sample
@FritzHeiden
Implemented unit test structure for CmcdModel class
c6dd6e8
@FritzHeiden
Implemented unit test for CMCD metrics of media request
78be8be
@FritzHeiden
Implemented unit test for CMCD metrics for MPD requests
e9187c0
@FritzHeiden
Implemented unit test for CMCD metrics of init segments and other
6a0c24b
@FritzHeiden
Forced deadline metric to be rounded
80b0fc1
@FritzHeiden FritzHeiden changed the title Feature cmcd spec update CMCD update Oct 5, 2020
@FritzHeiden FritzHeiden requested a review from dsilhavy October 5, 2020 08:34
@FritzHeiden
Added playback rate parameter (pr)
01a0401 
Added tests for registered events of CmcdModel
@dsilhavy dsilhavy added this to the 3.2.0 milestone Oct 7, 2020
@dsilhavy
Copy link
Collaborator

dsilhavy commented Oct 7, 2020

  • Updated Typescript index file
  • Send media type specific su and bs
  • Updated unit tests

@dsilhavy dsilhavy merged commit aa033ca into Dash-Industry-Forum:development Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsilhavy dsilhavy Awaiting requested review from dsilhavy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.2.0
Development

Successfully merging this pull request may close these issues.

Update Common-Media-Client-Data implementation
2 participants
@FritzHeiden @dsilhavy