Refactor EventBus #3372
Refactor EventBus #3372
Conversation
- add possibility to trigger events for specific stream id and media type, only listenesr that have been created for the given stream id and media type are called - add getStreamId() and getType() for classes, used by EventBus to filter listeners - remove all tests in listener methods to check for correct stream id and media type
src/core/EventBus.js
Outdated
| @@ -75,17 +82,33 @@ function EventBus() { | |||
| handlers[type][idx] = null; | |||
| } | |||
|
|
|||
| function trigger(type, payload) { | |||
| function trigger(type, payload = {}, streamId = undefined, mediaType = undefined) { | |||
There was a problem hiding this comment.
We are currently working on #3379 and would like to introduce an additional parameter in the trigger function as well. In order to align this and avoid a large constructor I suggest we make the third parameter and object {streamId,mediaType,additonalParameter}. That way we can enhance it even further later
There was a problem hiding this comment.
Why not enriching payload parameter with all these additional parameters? for example:
eventBus.trigger(Events.INIT_FRAGMENT_NEEDED, {
streamId: streamInfo.id,
mediaType: type,
representationId: currentRepresentationInfo.id
});
There was a problem hiding this comment.
I prefer having a third object in the function for all internal attributes which are not supposed to be dispatched to the client/app
There was a problem hiding this comment.
OK I see
we may get heavier source code, but nevermind
So this could be a 3rd function parameter called 'filters'? Or this may contains other parameters that could have other utility than even filtering?
There was a problem hiding this comment.
Yes basically everything which we can use for filtering and decision making when triggering the event. We will adjust the PR/request accordingly: #3379
This reverts commit e6ddd34.
The goal of this PR is to refactor the EventBus, mainly to add the possibility to listen for events for a specific stream id (period) and a adaptation/media type.