-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix intermittently failing unit test #1014
Comments
That looks like a float issue, this could be a pain. |
Yeah i think so. Never happened before in 1.x code so need to investigate this one. |
The unit test fails when the current time value of "new Date()" in To make the value of the start time of the segmentAvailabilityRange be 0 as in dash.TimeLineConverterSpec.js, some time buffer needs to be added to set the availiabilityStartTime, like following: |
I think using The two pending tests are never run (the test specs have been changed to |
…longer appropriate following refactor
There are two test that stay pending and one that intermittently fails.
FragmentModel
- should not be postponed after creation
✓ should not have any loading, executed, canceled or failed requests
when a request has been added
✓ should fire streamCompleted event for a complete request
when a request has been passed for executing
✓[90m should fire loadingStarted event a request
- should remove the request from pending requests
✓ should add the request to loading requests
✓ should be able to abort loading requests
31 passing (1s)
2 pending
1 failing
AssertionError: expected 0.0009999999999976694 to equal 0
-0.0009999999999976694
+0
The text was updated successfully, but these errors were encountered: