Update logic in receiver to look for either transient headers or non-transient headers#6
Merged
DarshitChanpura merged 4 commits intoDarshitChanpura:perf-bug-2724from Jul 5, 2023
Conversation
Signed-off-by: Craig Perkins <cwperx@amazon.com>
…eaders Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
cwperks
force-pushed
the
perf-bug-2724-craig
branch
from
9163357 to
219b0b3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the logic in the SecurityRequestHandler to look to see whether transient (non-serialized) headers are present in the ThreadContext or if non-transient (serialized) headers are present. If transient headers are present, no deserialization needs to take place. If serialized headers are present than it will deserialized. The logic to determine whether to serialized headers or not is only placed in the sender. The headers will be serialized for requests to remote nodes, but no serialization should take place for requests on the local node.