Skip to content

Revert "Revert "compare merge automatically merged.""#46

Merged
Dargon789 merged 1 commit into
Dargon789-patch-1from
revert-39-revert-31-master
Mar 13, 2025
Merged

Revert "Revert "compare merge automatically merged.""#46
Dargon789 merged 1 commit into
Dargon789-patch-1from
revert-39-revert-31-master

Conversation

@Dargon789

@Dargon789 Dargon789 commented Mar 13, 2025

Copy link
Copy Markdown
Owner

Reverts #39

Summary by Sourcery

Reverts the changes made by #39.

Chores:

  • Reverts changes to issue templates, removing package labels.
  • Reverts changes to package-lock.json.
  • Removes the addition of codacy.yml, eslint.yml, bug_report.md, config.yml, SECURITY.md, feature_request.md and custom.md.

@codesandbox

codesandbox Bot commented Mar 13, 2025

Copy link
Copy Markdown

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@bolt-new-by-stackblitz

Copy link
Copy Markdown

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@vercel

vercel Bot commented Mar 13, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ethereumjs-vite-vue-project ❌ Failed (Inspect) Mar 13, 2025 8:34pm

@sourcery-ai

sourcery-ai Bot commented Mar 13, 2025

Copy link
Copy Markdown

Reviewer's Guide by Sourcery

This pull request reverts a previous revert, restoring several files and configurations. It reintroduces the labels field to issue templates, updates the body-parser dependency, adds new workflow files for Codacy and ESLint, introduces new issue templates, includes a CircleCI configuration file, adds a security policy file, and adds a CNAME file.

Updated class diagram for issue templates

classDiagram
    class IssueTemplate {
        -name: string
        -about: string
        -title: string
        -labels: string
        -assignees: string
    }
    note for IssueTemplate "Restored labels field in issue templates"
Loading

File-Level Changes

Change Details Files
Reverts the removal of labels from issue templates.
  • Restores the labels field in the issue templates for various packages and the monorepo.
.github/ISSUE_TEMPLATE/package--ethereumjs-block.md
.github/ISSUE_TEMPLATE/package--ethereumjs-blockchain.md
.github/ISSUE_TEMPLATE/package--ethereumjs-client.md
.github/ISSUE_TEMPLATE/package--ethereumjs-common.md
.github/ISSUE_TEMPLATE/package--ethereumjs-devp2p.md
.github/ISSUE_TEMPLATE/package--ethereumjs-ethash.md
.github/ISSUE_TEMPLATE/package--ethereumjs-evm.md
.github/ISSUE_TEMPLATE/package--ethereumjs-statemanager.md
.github/ISSUE_TEMPLATE/package--ethereumjs-trie.md
.github/ISSUE_TEMPLATE/package--ethereumjs-tx.md
.github/ISSUE_TEMPLATE/package--ethereumjs-util.md
.github/ISSUE_TEMPLATE/package--ethereumjs-verkle.md
.github/ISSUE_TEMPLATE/package--ethereumjs-vm.md
.github/ISSUE_TEMPLATE/package--monorepo.md
.github/ISSUE_TEMPLATE/package--rlp.md
.github/ISSUE_TEMPLATE/general.md
Updates the body-parser dependency version.
  • Updates the body-parser dependency from version 1.19.2 to 1.20.3.
packages/client/package.json
Adds new workflow files for Codacy and ESLint.
  • Adds a codacy.yml workflow file for security scanning.
  • Adds an eslint.yml workflow file for linting.
.github/workflows/codacy.yml
.github/workflows/eslint.yml
Adds new issue templates.
  • Adds a bug_report.md issue template.
  • Adds a feature_request.md issue template.
  • Adds a custom.md issue template.
.github/ISSUE_TEMPLATE/bug_report.md
.github/ISSUE_TEMPLATE/feature_request.md
.github/ISSUE_TEMPLATE/custom.md
Adds a CircleCI configuration file.
  • Adds a config.yml file for CircleCI configuration.
.circleci/config.yml
Adds a security policy file.
  • Adds a SECURITY.md file outlining the project's security policy.
SECURITY.md
Adds a CNAME file.
  • Adds a CNAME file.
CNAME

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@snyk-io

snyk-io Bot commented Mar 13, 2025

Copy link
Copy Markdown

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Dargon789 - I've reviewed your changes - here's some feedback:

Overall Comments:

  • This PR introduces a lot of new files - can you confirm these were intended to be added?
  • It looks like the package-lock.json file has been updated, can you confirm this was intentional?
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@socket-security

Copy link
Copy Markdown

New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@vitest/browser@0.32.20.32.4 Transitive: environment, filesystem, network, shell +31 189 MB oreanno
npm/body-parser@1.20.21.20.3 Transitive: environment, eval, filesystem, unsafe +14 849 kB ulisesgascon

🚮 Removed packages: npm/rustbn-wasm@0.4.0

View full report↗︎

@Dargon789 Dargon789 merged commit 9879498 into Dargon789-patch-1 Mar 13, 2025
@Dargon789 Dargon789 deleted the revert-39-revert-31-master branch March 13, 2025 20:44
Dargon789 added a commit that referenced this pull request Apr 18, 2025
* compare merge automatically merged. (#31)

* Circleci project setup (#15)

* Add .circleci/config.yml

* Delete azure-pipelines.yml

* Create SECURITY.md

# Security Policy

## Supported Versions

Use this section to tell people about which versions of your project are
currently being supported with security updates.

| Version | Supported          |
| ------- | ------------------ |
| 5.1.x   | ✅ |
| 5.0.x   | ❌                |
| 4.0.x   | ✅ |
| < 4.0   | ❌                |

## Reporting a Vulnerability

Use this section to tell people how to report a vulnerability.

Tell them where to go, how often they can expect to get an update on a
reported vulnerability, what to expect if the vulnerability is accepted or
declined, etc.

* build(deps): bump the npm_and_yarn group across 1 directory with 2 updates (#16)

Bumps the npm_and_yarn group with 2 updates in the / directory: [webdriverio](https://github.com/webdriverio/webdriverio/tree/HEAD/packages/webdriverio) and [micromatch](https://github.com/micromatch/micromatch).


Updates `webdriverio` from 8.13.12 to 9.0.9
- [Release notes](https://github.com/webdriverio/webdriverio/releases)
- [Changelog](https://github.com/webdriverio/webdriverio/blob/main/CHANGELOG.md)
- [Commits](https://github.com/webdriverio/webdriverio/commits/v9.0.9/packages/webdriverio)

Updates `micromatch` from 4.0.5 to 4.0.8
- [Release notes](https://github.com/micromatch/micromatch/releases)
- [Changelog](https://github.com/micromatch/micromatch/blob/master/CHANGELOG.md)
- [Commits](micromatch/micromatch@4.0.5...4.0.8)

---
updated-dependencies:
- dependency-name: webdriverio
  dependency-type: indirect
  dependency-group: npm_and_yarn
- dependency-name: micromatch
  dependency-type: indirect
  dependency-group: npm_and_yarn
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Create codacy.yml

* build(deps): bump the npm_and_yarn group across 1 directory with 2 updates (#18)

Bumps the npm_and_yarn group with 2 updates in the / directory: [body-parser](https://github.com/expressjs/body-parser) and [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite).


Updates `body-parser` from 1.20.2 to 1.20.3
- [Release notes](https://github.com/expressjs/body-parser/releases)
- [Changelog](https://github.com/expressjs/body-parser/blob/master/HISTORY.md)
- [Commits](expressjs/body-parser@1.20.2...1.20.3)

Updates `vite` from 4.5.3 to 4.5.5
- [Release notes](https://github.com/vitejs/vite/releases)
- [Changelog](https://github.com/vitejs/vite/blob/v4.5.5/packages/vite/CHANGELOG.md)
- [Commits](https://github.com/vitejs/vite/commits/v4.5.5/packages/vite)

---
updated-dependencies:
- dependency-name: body-parser
  dependency-type: direct:production
  dependency-group: npm_and_yarn
- dependency-name: vite
  dependency-type: indirect
  dependency-group: npm_and_yarn
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* build(deps): bump the npm_and_yarn group across 1 directory with 2 updates (#19)

Bumps the npm_and_yarn group with 2 updates in the / directory: [rollup](https://github.com/rollup/rollup) and [@vitest/browser](https://github.com/vitest-dev/vitest/tree/HEAD/packages/browser).


Updates `rollup` from 3.29.4 to 4.22.4
- [Release notes](https://github.com/rollup/rollup/releases)
- [Changelog](https://github.com/rollup/rollup/blob/master/CHANGELOG.md)
- [Commits](rollup/rollup@v3.29.4...v4.22.4)

Updates `rollup` from 4.21.3 to 4.22.4
- [Release notes](https://github.com/rollup/rollup/releases)
- [Changelog](https://github.com/rollup/rollup/blob/master/CHANGELOG.md)
- [Commits](rollup/rollup@v3.29.4...v4.22.4)

Updates `@vitest/browser` from 0.32.2 to 2.1.1
- [Release notes](https://github.com/vitest-dev/vitest/releases)
- [Commits](https://github.com/vitest-dev/vitest/commits/v2.1.1/packages/browser)

---
updated-dependencies:
- dependency-name: rollup
  dependency-type: indirect
  dependency-group: npm_and_yarn
- dependency-name: rollup
  dependency-type: indirect
  dependency-group: npm_and_yarn
- dependency-name: "@vitest/browser"
  dependency-type: indirect
  dependency-group: npm_and_yarn
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Create eslint.yml

Signed-off-by: Legion's  <64915515+Dargon789@users.noreply.github.com>

* Update issue templates

* build(deps): bump the npm_and_yarn group across 1 directory with 3 updates (#28)

Bumps the npm_and_yarn group with 3 updates in the / directory: [cross-spawn](https://github.com/moxystudio/node-cross-spawn), [nanoid](https://github.com/ai/nanoid) and [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite).


Updates `cross-spawn` from 7.0.3 to 7.0.6
- [Changelog](https://github.com/moxystudio/node-cross-spawn/blob/master/CHANGELOG.md)
- [Commits](moxystudio/node-cross-spawn@v7.0.3...v7.0.6)

Updates `nanoid` from 3.3.7 to 3.3.8
- [Release notes](https://github.com/ai/nanoid/releases)
- [Changelog](https://github.com/ai/nanoid/blob/main/CHANGELOG.md)
- [Commits](ai/nanoid@3.3.7...3.3.8)

Updates `vite` from 4.5.5 to 4.5.9
- [Release notes](https://github.com/vitejs/vite/releases)
- [Changelog](https://github.com/vitejs/vite/blob/v4.5.9/packages/vite/CHANGELOG.md)
- [Commits](https://github.com/vitejs/vite/commits/v4.5.9/packages/vite)

---
updated-dependencies:
- dependency-name: cross-spawn
  dependency-type: indirect
  dependency-group: npm_and_yarn
- dependency-name: nanoid
  dependency-type: indirect
  dependency-group: npm_and_yarn
- dependency-name: vite
  dependency-type: indirect
  dependency-group: npm_and_yarn
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Create CNAME

* Update CNAME

* Revert "build(deps): bump the npm_and_yarn group across 1 directory with 2 up…" (#30)

This reverts commit 5f22892.

---------

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Legion's  <64915515+Dargon789@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Revert "compare merge automatically merged. (#31)" (#39)

This reverts commit 3a68385.

* Revert "Revert "compare merge automatically merged. (#31)" (#39)" (#46)

This reverts commit bce0b73.

---------

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Legion's  <64915515+Dargon789@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant