Run the main build on every push to main, not just root-file pushes - #2238
Merged
Merged
Conversation
main.yml filtered pushes with paths: - '*' - '!/docs/*' GitHub's `*` does not cross a '/', so `'*'` matches only files at the repository root. Any push touching just Dapper/, tests/ or another subdirectory failed the filter and the build was skipped - silently, because a skipped workflow is not a failure. Checking main: 8becae8 (#2230) 4 root files ran 2ca8261 (#2223) 1 root file ran 6d48ef6 (#2228) 0 root files skipped 41d76c7 (#2225) 0 root files skipped So most merges to main never built at all. The second line never worked either: path filters are repo-relative and take no leading slash, so '!/docs/*' matched nothing - the docs exclusion it was written for was already being done, by accident, by the '*' that excluded every subdirectory. paths-ignore: 'docs/**' says what was meant: run for everything except a docs-only change. This matters more than it used to. release.yml takes its version from what a green main run reports, so a main build that never runs means no version to tag with - which is how this was noticed.
This was referenced Sep 23, 2026
This was referenced Sep 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pushes to
mainmostly don't build, which makes it hard to read off the version to tag arelease with.
Cause
GitHub's
*doesn't cross a/, so'*'matches only root-level files. A push touchingjust
Dapper/ortests/fails the filter and is skipped — silently, since a skipped workflowisn't a failure.
8becae8(#2230)2ca8261(#2223)6d48ef6(#2228)41d76c7(#2225)The
'!/docs/*'line never worked either — path filters are repo-relative and take no leadingslash, so it matched nothing. The docs exclusion it was written for was happening by accident,
via the
'*'that already excluded every subdirectory.Fix
Which is what was meant: build everything except a docs-only change.
Why it matters now
release.ymlreads the version to tag from a green main run's summary. A main build that neverruns means no version — which is how this surfaced. PR builds were unaffected throughout (the
pull_requesttrigger has no path filter), so CI looked healthy.Merge order
Worth merging before #2237: that one only touches
Dapper.StrongName/andDapper.EntityFramework.StrongName/, so under the current filter it would merge withoutproducing a main run or a version. This PR's own merge commit will build, since
pusheventsevaluate the workflow file at the pushed commit.