Fix long MSVC linker commands on Windows#2517
Merged
Merged
Conversation
Use a temporary response file when setuptools emits an oversized link.exe command so Windows builds with many object files can complete. Made-with: Cursor
Contributor
Author
|
For anyone looking to build |
Contributor
Author
|
@rocking5566 @tridao PTAL. This will fix a long-standing issue of compiling flash-attention with CK backend on Windows. Once distutils PR gets merged and percolates, we can revert this change. But that will take a long time, so this solution is best to be merged in the short-medium term. |
tridao
approved these changes
Apr 29, 2026
ussoewwin
pushed a commit
to ussoewwin/flash-attention
that referenced
this pull request
May 13, 2026
Use a temporary response file when setuptools emits an oversized link.exe command so Windows builds with many object files can complete. Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar fix as pypa/distutils#406
Bringing this fix here as new distutils updates may take time to percolate across the community. This PR will immediately unblock users who would like to build flash-attention on RDNA3/4 on windows (#2054)