[Cute,Sm120] fix Spark forward and backward regressions - #2474
Open
CuriousCaliBoi wants to merge 1 commit into
Open
CuriousCaliBoi wants to merge 1 commit into
CuriousCaliBoi wants to merge 1 commit into
Conversation
Restore the intended SM80-style control flow for SM120 forward and initialize the SM120 backward config so FA4 compiles and runs end to end on DGX Spark. Keep the shared SM80/SM120 backward launcher on concrete softmax-scale values to avoid DSL type errors, and add a regression test for the SM120 control-flow selection. Made-with: Cursor
3 tasks done
Contributor
|
Validated this on DGX Spark / GB10 (SM121). Env:
Results:
Max diffs vs PyTorch SDPA stayed in the expected fp16/bf16 range; worst observed was |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FlashAttentionForwardSm120so DGX Spark does not fall into the TMA epilogue path at runtimedQ_single_wgstate and keep the shared SM80/SM120 backward launcher on concrete softmax-scale values so the Spark backward path compiles cleanly againArch.sm_80Test plan
NVIDIA GB10/ compute capability12.1B=8, S=8192, H=32, D=64, causal=False: FA446.52 ms / 94.5 TFLOPS, SDPA50.18 ms / 87.6 TFLOPSFlashAttentionForwardSm120directly and verify the effective arch staysArch.sm_80Made with Cursor