[ROCm] Guard distributed usage with hasattr for Windows compatibility#2208
Closed
0xDELUXA wants to merge 0 commit intoDao-AILab:mainfrom
Closed
[ROCm] Guard distributed usage with hasattr for Windows compatibility#22080xDELUXA wants to merge 0 commit intoDao-AILab:mainfrom
distributed usage with hasattr for Windows compatibility#22080xDELUXA wants to merge 0 commit intoDao-AILab:mainfrom
Conversation
distributed to improve compatibility with ROCm on Windows
distributed to improve compatibility with ROCm on Windowshasattr checks for distributed to improve compatibility with ROCm on Windows
hasattr checks for distributed to improve compatibility with ROCm on Windowsdistributed usage with hasattr for Windows compatibility
02452eb to
863aee0
Compare
863aee0 to
57cef6c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without these checks, ROCm on Windows raises an
AttributeErrorwhen importing certain distributed functions.For example, when adding a custom node to ComfyUI:
This PR adds
hasattrchecks to prevent this error. It is not expected to cause any issues on Nvidia or Linux.Environment details
GPU: AMD Radeon RX 9060 XT
Python: 3.12.10
PyTorch: 2.11.0a0+rocm7.11.0a20260121 (TheRock)
Triton: 3.6.0a0.post25 (triton-windows)
OS: Windows 11
Edit:
Migrated to ROCm#172.