Conversation
|
|
||
| // Copied from https://github.com/pytorch/pytorch/commit/7931eee5c5ebcdf468bff4d308510b03355cd909 | ||
| // This is so that we can pass in torch.dtype as a parameter to the function. | ||
| #if TORCH_VERSION_MAJOR < 2 || (TORCH_VERSION_MAJOR == 2 && TORCH_VERSION_MINOR < 4) |
There was a problem hiding this comment.
Note: I had to remove this because we're no longer using PyBind. This will probably break with PyTorch < 2.4, is this fine, or do we want a backup solution for older PyTorch versions?
There was a problem hiding this comment.
that's fine, we won't support pytorhc < 2.4
janeyx99
left a comment
janeyx99
left a comment
There was a problem hiding this comment.
Looks good from my perspective! Thanks Daniel for taking this on! Did you locally verify this change?
|
I created a wheel with cp39, and installed in on a cp39 and cp312 env. The import seemed to work: |
Would be best to also run the existing test cases for both envs! |
Co-authored-by: Jane (Yuan) Xu <31798555+janeyx99@users.noreply.github.com>
|
we are using pytorch 2.7.0 + cuda 12.8 hardware with cuda 12.6 lib + python 3.10 and we are seeing build issues after this commit, have you verified that python3.10 works? |
|
@danthe3rd Could this be backported to FA2 in the meantime too since it seems there are issues with the current wheels #1717 ? |
Hi, |
* Use Python stable ABI * Remove useless macro * Add 'py_limited_api=True' * Default value for 'num_splits' * Update hopper/flash_api.cpp Co-authored-by: Jane (Yuan) Xu <31798555+janeyx99@users.noreply.github.com> --------- Co-authored-by: Tri Dao <tridao@users.noreply.github.com> Co-authored-by: Jane (Yuan) Xu <31798555+janeyx99@users.noreply.github.com>
* Use Python stable ABI * Remove useless macro * Add 'py_limited_api=True' * Default value for 'num_splits' * Update hopper/flash_api.cpp Co-authored-by: Jane (Yuan) Xu <31798555+janeyx99@users.noreply.github.com> --------- Co-authored-by: Tri Dao <tridao@users.noreply.github.com> Co-authored-by: Jane (Yuan) Xu <31798555+janeyx99@users.noreply.github.com>
5 participants
This should enable us to build a single wheel for all python versions
(still requires a different build per OS/PyTorch version)