WIP: Fix Breaking Changes for A-Frame Version 1.5.0 #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…omething else seems to be wrong additionally. Checking out what's going on.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
It gets rid of some of the bright red errors that were showing up as breaking changes as noted here:
#6
That said, it seems like there might be a few more issues which is causing it not to load so I'm going to keep poking this till the lights turn back on. I did opt to try and make this both compatible with A-Frame Version 1.5 and below. So this shouldn't cause breaking changes if someone grabs the latest version and implements it on 1.3. That said, I also updated the README.MD to suggest that users do switch to the newest version of A-Frame if they use this (when it's fixed).