Add support for Xiaomi Vibration sensor#89
Merged
Danielhiversen merged 2 commits intoDanielhiversen:masterfrom Sep 13, 2018
Merged
Add support for Xiaomi Vibration sensor#89Danielhiversen merged 2 commits intoDanielhiversen:masterfrom
Danielhiversen merged 2 commits intoDanielhiversen:masterfrom
Conversation
Collaborator
|
Please provide some example responses of the device. |
Contributor
Author
|
You can view the full integration at this Pull Request: Here are some sample outputs from this sensor... |
Owner
|
Please rebase your branch on the latest master branch to fix the failing tests |
8 tasks
Owner
|
@syssi Any more comments? |
Collaborator
|
Sorry for the late feedback. I'm waiting for my sensor. The PR is fine! Good job! |
This was referenced Sep 16, 2018
luci-11
pushed a commit
to luci-11/PyXiaomiGateway
that referenced
this pull request
Sep 20, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.