Remove checkboxgroup role

DanielTurner · Oct 7, 2018 · cf61dbf · cf61dbf
1 parent ea6d0db
commit cf61dbf
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/src/vaadin-checkbox-group.html b/src/vaadin-checkbox-group.html
@@ -167,8 +167,6 @@
         ready() {
           super.ready();
 
-          this.setAttribute('role', 'checkboxgroup');
-
           this.addEventListener('focusout', e => {
             // validate when stepping out of the checkbox group
             if (!this._checkboxes.some(checkbox => e.relatedTarget === checkbox || checkbox.shadowRoot.contains(e.relatedTarget))) {

diff --git a/test/vaadin-checkbox-group_test.html b/test/vaadin-checkbox-group_test.html
@@ -62,8 +62,8 @@
       vaadinCheckboxGroup._observer.flush();
     });
 
-    it('sets role properly', () => {
-      expect(vaadinCheckboxGroup.getAttribute('role')).to.eq('checkboxgroup');
+    it('does not set a role', () => {
+      expect(vaadinCheckboxGroup.getAttribute('role')).to.eq(null);
     });
 
     it('changes aria-disabled on disabled change', () => {