Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update TepperBuilder methods to retain Types #272

Merged
merged 2 commits into from
Nov 14, 2022
Merged

Update TepperBuilder methods to retain Types #272

merged 2 commits into from
Nov 14, 2022

Conversation

gustavogr
Copy link
Collaborator

The types declared using .get<...> were getting lost when further using methods like .withQuery(...).

This PR address that by simply indicating Typescript to maintain the typings when creating new instances of TepperBuilder

DanielRamosAcosta
DanielRamosAcosta approved these changes Nov 14, 2022
View reviewed changes
Copy link
Owner

@DanielRamosAcosta DanielRamosAcosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just bump the version at package.json @gustavogr

@DanielRamosAcosta DanielRamosAcosta merged commit 67191de into main Nov 14, 2022
@DanielRamosAcosta DanielRamosAcosta deleted the fix/operators-losing-types branch November 14, 2022 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielRamosAcosta DanielRamosAcosta DanielRamosAcosta approved these changes

Assignees

@gustavogr gustavogr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gustavogr @DanielRamosAcosta