-
-
Notifications
You must be signed in to change notification settings - Fork 8
Make every formatter optional 2 #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1662310150
💛 - Coveralls |
Collaborator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see what you want to do now. It would work but I think using confuse (and as long as we have no config argparse's default argument) would be less verbose and require less code to maintain on our side. Did you check confuse :) ?
Pierre-Sassoulas
pushed a commit
that referenced
this pull request
Jan 8, 2022
See discussion here: #15 (comment) And here #21
Collaborator
|
Closing after cherry-picking and rebasing on #15 |
Pierre-Sassoulas
pushed a commit
that referenced
this pull request
Jan 8, 2022
See discussion here: #15 (comment) And here #21
Pierre-Sassoulas
pushed a commit
that referenced
this pull request
Jan 8, 2022
See discussion here: #15 (comment) And here #21
Pierre-Sassoulas
pushed a commit
that referenced
this pull request
Jan 8, 2022
See discussion here: #15 (comment) And here #21
Pierre-Sassoulas
pushed a commit
that referenced
this pull request
Jan 8, 2022
See discussion here: #15 (comment) And here #21
Pierre-Sassoulas
added a commit
that referenced
this pull request
Jan 8, 2022
* Add automatically generated options * Refactor to avoid using a default value in argparse See discussion here: #15 (comment) And here #21 Co-authored-by: Daniël van Noord <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP.
Just to show how I would do the changes proposed in #15.
@Pierre-Sassoulas I'd still like to merge L19 and L20 (and possible create an
ArgumentManagerclass to handle all of this a bit better), but with this approach (to me) it's much clearer where all options come from and where they get their value. By doing the default value parsing just before parsing all other configuration sources you know where any expected values could come from.