Add the --style option
#138
Conversation
This comment has been minimized.
This comment has been minimized.
Currently only supports ``--style pep257``
This comment has been minimized.
This comment has been minimized.
|
According to the primer, this change has no effect on the checked open source code. 🤖🎉 |
Codecov Report
@@ Coverage Diff @@
## main #138 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 19 19
Lines 478 481 +3
=========================================
+ Hits 478 481 +3
|
| Docstring styles that are used in the project. Can be | ||
| more than one. |
There was a problem hiding this comment.
It means we'll have to detect which style is which given a docstring. We have something who does that in pylint, we might extract it to make something generic...
There was a problem hiding this comment.
Yeah that's the next step.
Although I don't really like the difficult regexes pylint uses. I'd rather build them from scratch here and see if we can keep them a little bit simpler.
We need less information that pylint needs to extract from the regexes anyway as we don't really care about the content of the docstrings...
There was a problem hiding this comment.
I'd rather build them from scratch here and see if we can keep them a little bit simpler.
Then it's an opportunity to remove the complicated regexes from pylint and instead of extracting we replace them 😄
Currently only supports
--style pep257