Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove vscode:prepublish and split build and package scripts #256

Merged
merged 1 commit into from
Oct 6, 2023

Conversation

thetarnav
Copy link
Contributor

The vscode:prepublish script were causing compile script to be executed twice when running npm run package.

Also I've split package to build and package so that the extension can be quickly rebundled when I've only changed the grammars.

$ npm run package

> [email protected] package
> npm run compile && vsce package -o extension.vsix


> [email protected] compile
> tsc -p ./

Executing prepublish script 'npm run vscode:prepublish'...

> [email protected] vscode:prepublish
> npm run compile


> [email protected] compile
> tsc -p ./

This extension consists of 288 files, out of which 211 are JavaScript files. For performance reasons, you should...

@DanielGavin DanielGavin merged commit 5d33af9 into DanielGavin:master Oct 6, 2023
3 checks passed
@thetarnav thetarnav deleted the update-npm-scipts branch October 6, 2023 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants