Added AudioClip Events and Listener #95
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added pragma warning disable for private serialized field, prevents warning in Unity console.
* Created AudioClip UnityEvent, GameEvent, and Listener.
|
Hey, I realize you're probably busy; just bumping this as a reminder. |
|
No worries, I'll probably find time this weekend :) |
|
Appreciate it! Thanks Daniel Sent with GitHawk |
|
Thanks for the PR! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Over the last few game jams, I've used a one-off audio playing system each time which listened to an AudioClip GameEvent to allow other systems to be able to play audio in a decoupled way. I've done it enough to where I believe this would be a viable, generally useful addition to the core ScriptableArchitecture library. For this I've created the following:
I did not add any icons to the scripts listed above, but that would also be a good thing to do before this is merged in.
In addition, I've hidden a warning via #pragma in the console that appears for private serialized fields in SceneVariable that is a false positive.