Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Host list AntiMalwareHosts.txt, 8 invalid entries #1046

Closed
RichardBeisser opened this issue Jul 7, 2024 · 2 comments
Closed

Host list AntiMalwareHosts.txt, 8 invalid entries #1046

RichardBeisser opened this issue Jul 7, 2024 · 2 comments

Comments

@RichardBeisser
Copy link

Describe the problem below this line as meticulously and detailed as possible (incl. pagelinks if any)

Hello,
File AntiMalwareHosts.txt is a Host-List, but it contains non-domain entries:

[i] Target: https://raw.githubusercontent.com/DandelionSprout/adfilt/master/Alternate%20versions%20Anti-Malware%20List/AntiMalwareHosts.txt
[✓] Status: Retrieval successful
[✓] Parsed 23503 exact domains and 0 ABP-style domains (ignored 8 non-domain entries)
Sample of non-domain entries:
- "5.8.47.3"
- "190.238.183.5"
- "85.239.33.9"
- "113.116.89.1"
- "182.116.104.6"

Add screenshots below if needed

No response

Add a screenshot of the extension's logger

No response

Which adblocker(s) did you use when testing this?

Pi-hole (Support may be limited)

Adblocker version(s)

No response

Which filterlists did you use? Failing to tell this with at least 10 letters or 1 image, will close the report until it has been told.


Which browser(s) did you use when testing this?

Firefox (incl. LibreFox)

Browser version(s)


Which OS(s) did you use when testing this?

Windows 11

OS version(s)

No response

@iam-py-test
Copy link
Collaborator

iam-py-test commented Jul 7, 2024

This is intentional:

I remember faintly from around 2020 that IPs in the domains list version was intentional, just in case someone tried to use that list version with software that supported IP blocking. On top of that, non-existent community communication by Pi-hole devs meant I couldn't rule out that Pi-Hole supported such IP blocking.

As it stands, I'm inclined to let the IPs remain, but could reconsider if any domains blocking tools out there were to discard entire lists with unsupported entries (There was a similar incident involving DNSMASQ last week).

Thank you

Related ! is not a valid comment in a HOSTs file, but the commented out TLDs appear as
!!!||ooo
!!!||monster
!!!||sbs
!!!||discount
!!!||cfd

@DandelionSprout
Copy link
Owner

While I admit that there was no 100% certain answer to the report's core question (Whether IP addresses should be in a hostfile), I began recommending sometime after the report was opened that Pi-hole users should use https://raw.githubusercontent.com/DandelionSprout/adfilt/refs/heads/master/Alternate%20versions%20Anti-Malware%20List/AntiMalwareAdGuardHome.txt instead of the hostfile version.

The way I understood things (The Pi-hole devs have completely non-existent interactivity with any other adblocking communities), Pi-hole (re?)introduced support for ||-type entries in v5.22 (||-type entries usually doesn't run into errors with IP addresses), and I take an unqualified guess that most Pi-hole users have updated to that version or higher by now.

DandelionSprout added a commit that referenced this issue Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants