Closes: #65 - Add Search indexes #108
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanSheps
requested changes
Oct 22, 2025
DanSheps
approved these changes
Oct 22, 2025
DanSheps
reviewed
Oct 22, 2025
DanSheps
reviewed
Oct 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #65 - Add Search indexes
Adds functionality to search for all major models this plugin provides.
This is basically the followup to #65, we have been using this patch since I opened this issue and it has been working great for us!
One consideration, I had to change the visual output for the static routes name, this only shows up in the header of the static route detail page so far, but without this change it's rather confusing when searching for the route names. (and the information is visible in other fields around anyways)
Consideration 2, in the meantime netbox has added guidance on which search field weights should be used, these don't fully allign right now, but are adjusted hopefully well enough.
Gladly will make any changes if necessary!
Cheers, lumarel