-
-
Notifications
You must be signed in to change notification settings - Fork 13
unique device name and routing instace combination #101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
DanSheps
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will also require a migration which seems to be missing.
Head branch was pushed to by a user without write access
917ae46 to
338f946
Compare
Co-authored-by: Daniel Sheppard <[email protected]>
Co-authored-by: Daniel Sheppard <[email protected]>
DanSheps
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the Ruff failures and change the black formatting back to 1
pyproject.toml
Outdated
| [tool.black] | ||
| skip-string-normalization = 1 | ||
| check = 1 | ||
| check = 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| check = 0 | |
| check = 1 |
|
At this point I don't know how to fix this migrations issues. I wasn't able to replicate it or fix it locally as pipeline suggests. |
You will want to update the branch from main as there is a another migration at the same "level" (has the same parent migration). Once updated, you will just need to rename your migration and change the parent migration to the one at 0016 still. |
…_and_more.py to 0017_eigrprouter_netbox_routing_eigrprouter_unique_device_name_and_more.py
...outing/migrations/0017_eigrprouter_netbox_routing_eigrprouter_unique_device_name_and_more.py
Outdated
Show resolved
Hide resolved
…prouter_unique_device_name_and_more.py
|
I fixed it for you, hopefully this one completes |
Thanks, this idea came through my mind, but I was too tired to try it. |
Fixes #100 and will not break existing instances.