Skip to content

Conversation

@mrhyks
Copy link
Contributor

@mrhyks mrhyks commented Aug 18, 2025

Fixes #100 and will not break existing instances.

Copy link
Owner

@DanSheps DanSheps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will also require a migration which seems to be missing.

auto-merge was automatically disabled October 29, 2025 12:55

Head branch was pushed to by a user without write access

@mrhyks mrhyks force-pushed the unique-name-on-device branch from 917ae46 to 338f946 Compare October 29, 2025 12:55
Copy link
Owner

@DanSheps DanSheps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the Ruff failures and change the black formatting back to 1

pyproject.toml Outdated
[tool.black]
skip-string-normalization = 1
check = 1
check = 0
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
check = 0
check = 1

@mrhyks
Copy link
Contributor Author

mrhyks commented Oct 30, 2025

At this point I don't know how to fix this migrations issues. I wasn't able to replicate it or fix it locally as pipeline suggests.

@DanSheps
Copy link
Owner

DanSheps commented Oct 30, 2025

At this point I don't know how to fix this migrations issues. I wasn't able to replicate it or fix it locally as pipeline suggests.

You will want to update the branch from main as there is a another migration at the same "level" (has the same parent migration).

Once updated, you will just need to rename your migration and change the parent migration to the one at 0016 still.

…_and_more.py to 0017_eigrprouter_netbox_routing_eigrprouter_unique_device_name_and_more.py
@DanSheps
Copy link
Owner

I fixed it for you, hopefully this one completes

@mrhyks
Copy link
Contributor Author

mrhyks commented Oct 31, 2025

I fixed it for you, hopefully this one completes

Thanks, this idea came through my mind, but I was too tired to try it.

@DanSheps DanSheps self-requested a review October 31, 2025 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unique combination of device name and routing instace

2 participants