Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lbuild now generates code for ms5611 #3

Merged
merged 2 commits into from
May 3, 2022
Merged

Conversation

rasmuskleist
Copy link

No description provided.

@rleh
Copy link

rleh commented Mar 15, 2022

@rasmuskleist Feel free to open a pull request at https://github.com/modm-io/modm, then I'll be happy to review the code and merge the driver directly into "upstream" modm. 🙂

@rasmuskleist
Copy link
Author

rasmuskleist commented Apr 27, 2022

I have had this lying around for a while now. There are some points I am not quite happy with yet. More precisely;

  1. The reinterpret_cast<uint16_t *>(&data.calibration) gives a compiler warning
  2. There is no guard on the readProm() preventing indices not in range 0..7
  3. It may be redundant to have rawTemperatureTouched and rawPressureTouched since it only makes sense to measure both at once

I would like to hear your thoughts?

@rleh
Copy link

rleh commented Apr 28, 2022

Moved to modm-io#851 (comment)

@rasmuskleist rasmuskleist merged commit ab9bcee into develop May 3, 2022
@twast92 twast92 deleted the feature-ms5611 branch May 5, 2022 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants