Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import updates to fix tool loading #6

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

montyevans
Copy link

@montyevans montyevans commented Jan 16, 2025

Fixes #5

  1. The absolute imports in npg_bool_hlp.py don't resolve correctly, so I moved them to be relative imports.
  2. In tbx_tools.py, the line from npg.npg_overlay import dissolve, merge_ has two issues:
    a. There is no function in the repo called dissolve, causing an import error. A quick read suggests this might be union_adj inside npg_bool_ops, so I've updated accordingly.
    b. The function merge_ exists in npg_bool_ops, not npg_overlay, so I've updated accordingly.

I've only tested this with a couple of tools, but it seems to run fine.

@montyevans montyevans changed the title Fixes https://github.com/Dan-Patterson/numpy_geometry/issues/5 Fixes #5 Jan 16, 2025
@montyevans montyevans changed the title Fixes #5 Various import updates to fix tool loading Jan 16, 2025
@montyevans montyevans changed the title Various import updates to fix tool loading Import updates to fix tool loading Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tbx_tools.py file fails to load when running any tool
1 participant