zad6 #262
Open
zad6 #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahawrylak
reviewed
Dec 11, 2018
| @@ -1,7 +1,7 @@ | |||
| source 'https://rubygems.org' | |||
| git_source(:github) { |repo| "https://github.com/#{repo}.git" } | |||
|
|
|||
| ruby '2.5.3' | |||
| ruby '2.5.1' | |||
There was a problem hiding this comment.
ruby 2.5.3 był jak najbardziej ok, nie trzeba było zmieniać wersji 😉 Żeby zainstalować brakującą wersję wystarczy puścić rvm install 2.5.3(zakładając, że używamy rvm, ale z tego co to było narzędzie pokazywane na wykładzie).
| class CustomersController < ApplicationController | ||
|
|
||
| def index | ||
| @customers = Customer.all |
There was a problem hiding this comment.
do wcięć w rubym używamy 2 spacji 😉
ahawrylak
reviewed
Dec 11, 2018
|
|
||
| def index | ||
| @customer = Customer.find(params[:customer_id]) | ||
| @products = @customer.products.order(price: :desc).includes(:categories) |
There was a problem hiding this comment.
O, jest nawet preloading categories - to celowo? 🤔 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Przepraszam, że tak słabo się to wszystko prezentuje wizualnie, ale z powodu zbliżających się kolokwiów nie mam w ogóle czasu 😢