Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zad5 #258

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Zad5 #258

wants to merge 2 commits into from

Conversation

kanibal01
Copy link

No description provided.

@resool resool added the zad5 label Dec 12, 2018
@resool resool self-requested a review December 12, 2018 12:20
get 'artists/index'
get 'artists/destroy'
get 'artists/create'
get 'artists/update'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

te linijki są zbędne ponieważ resources, który jest w linii 14 tworzy już 7 ścieżek CRUDowych:
https://guides.rubyonrails.org/routing.html#crud-verbs-and-actions

<td class="text-left"><%= artist.name %></td>
<td class="text-right">
<%= link_to 'edit', edit_artist_path(artist), class: 'btn btn-warning' %>
<%= link_to 'remove', artist_path(artist), method: :delete, class: 'btn btn-danger' %>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

można dodać data: { confirm: 'Are you sure?' }, aby przypadkiem nie usunąć niczego 🙈

@resool resool added the 👘 CR Code review left label Dec 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👘 CR Code review left zad5
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants