Integrate Neurotoxic Overworld Aesthetic into App #1388
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -507,10 +507,6 @@ | |
| "member": { | ||
| "unknown": "Unknown" | ||
| }, | ||
| "merch_press.button": "MERCH PRESS", | ||
| "merch_press.confirm": "START PRESS", | ||
| "merch_press.cost_label": "COST", | ||
|
|
@@ -602,22 +598,6 @@ | |
| "no_save_found": "No save game found!", | ||
| "nowPlaying": "Now Playing: {{name}}", | ||
| "overload.toxic": "TOXIC OVERLOAD", | ||
| "pirate_radio.button": "PIRATE RADIO", | ||
| "pirate_radio.controversy_gain": "CONTROVERSY", | ||
| "pirate_radio.cooldown": "ON COOLDOWN", | ||
|
|
@@ -985,5 +965,67 @@ | |
| "unit.km": "km", | ||
| "unlocked": "UNLOCKED: {{unlock}}!", | ||
| "visual_interface": "VISUAL INTERFACE", | ||
| "volume.set": "Set volume to {{pct}}%", | ||
| "menu": { | ||
| "management": "MANAGEMENT", | ||
| "hq_desc": "Manage members & gear", | ||
| "quests_desc": "Active objectives", | ||
| "stash_desc": "Contraband & inventory", | ||
| "side_hustles": "SIDE HUSTLES", | ||
| "radio_desc": "Boost reputation", | ||
| "merch_desc": "Print bootlegs", | ||
| "darkweb_desc": "Leak new tracks", | ||
| "logistics": "LOGISTICS", | ||
| "refuel_desc": "Gas up the van", | ||
| "repair_desc": "Fix van damage", | ||
| "bloodbank_desc": "Trade blood for cash", | ||
| "clinic_desc": "Heal members", | ||
| "system": "SYSTEM", | ||
| "save_desc": "Record progress", | ||
| "options_count": "options", | ||
| "actions": "ACTIONS", | ||
| "back_to_actions": "BACK TO ACTIONS", | ||
| "close": "CLOSE MENU", | ||
| "open": "OPEN MENU", | ||
| "options_count_upper": "OPTIONS", | ||
| "options_count_lower": "options", | ||
| "inventory": "INVENTORY", | ||
| "upgrades": "UPGRADES" | ||
| }, | ||
| "overworld": { | ||
| "shortcuts": { | ||
| "help": "Toggle Help", | ||
| "mute": "Mute / Unmute", | ||
| "event": "Select Event Option", | ||
| "hit_notes": "Hit Notes (Gig)", | ||
| "close": "Close Overlays" | ||
| }, | ||
| "low_fuel": "LOW FUEL", | ||
| "keyboard_shortcuts": "Keyboard Shortcuts", | ||
| "band_status": "Band Status", | ||
| "harmony": "Harmony", | ||
|
coderabbitai[bot] marked this conversation as resolved.
|
||
| "radio_station": "FM 66.6", | ||
| "event_log_entries": "entries", | ||
| "event_log_entries_one": "entry", | ||
| "event_log_entries_other": "entries", | ||
| "locations_loaded": "Tour initialized. {{count}} locations loaded.", | ||
| "tour_active": "{{date}}: Tour active.", | ||
| "location_secured": "{{location}} secured.", | ||
| "event_log": "EVENT LOG", | ||
| "header": { | ||
| "tourPlan": "TOUR PLAN" | ||
| }, | ||
|
coderabbitai[bot] marked this conversation as resolved.
|
||
| "status": { | ||
| "traveling": "TRAVELING...", | ||
| "nextStop": "Next Stop", | ||
| "onRoad": "ON THE ROAD", | ||
| "selectLocation": "SELECT A LOCATION" | ||
| }, | ||
| "band_hq_button": "BAND HQ", | ||
| "refuel": "REFUEL", | ||
| "repair": "REPAIR", | ||
| "void_clinic_button": "VOID CLINIC", | ||
| "save_game": "SAVE GAME", | ||
| "traveling_van": "Traveling Van" | ||
| } | ||
|
devin-ai-integration[bot] marked this conversation as resolved.
devin-ai-integration[bot] marked this conversation as resolved.
|
||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -24,3 +24,7 @@ Applies to everything under `src/` unless a deeper `AGENTS.md` overrides it. | |
|
|
||
| - `useArrivalLogic` owns arrival routing and scene transitions after travel completion. | ||
| - Minigame hooks (`useTourbusLogic`, `useRoadieLogic`) must stay reactive-only (no direct PIXI imports). | ||
|
|
||
| ## Recent Findings (2026-04) | ||
|
|
||
| - Theme-token migrations should be completed per file: if one module switches to RGB token variables, finish all remaining literal color usages in that module before merging. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -21,6 +21,7 @@ const SCENES_WITHOUT_HUD: Set<GamePhase> = new Set([ | |
| GAME_PHASES.SETTINGS, | ||
| GAME_PHASES.CREDITS, | ||
| GAME_PHASES.GAMEOVER, | ||
| GAME_PHASES.OVERWORLD, | ||
|
Contributor
There was a problem hiding this comment. 🚩 Global HUD suppression for Overworld is intentional but broad Adding 
Was this helpful? React with 👍 or 👎 to provide feedback. |
||
| GAME_PHASES.TRAVEL_MINIGAME, | ||
| GAME_PHASES.PRE_GIG_MINIGAME, | ||
| GAME_PHASES.CLINIC | ||
|
|
@@ -99,7 +100,7 @@ function GameContent() { | |
| <div className='crt-overlay pointer-events-none fixed inset-0 z-(--z-crt) mix-blend-overlay opacity-50' /> | ||
| )} | ||
|
|
||
| {/* Hide global HUD in scenes that provide their own overlays or no HUD UI. */} | ||
| {!SCENES_WITHOUT_HUD.has(currentScene) && <HUD />} | ||
|
|
||
| <ToastOverlay /> | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -19,3 +19,7 @@ Applies to `src/assets/**`. | |
| - Keep asset metadata interfaces narrow and explicit; avoid loosely typed loader payloads. | ||
| - If asset key/path conventions change, update typed import maps and all consuming loaders/tests together. | ||
| - Prefer additive metadata fields over repurposing existing keys to preserve backward compatibility with save fixtures and tests. | ||
|
|
||
| ## Recent Findings (2026-04) | ||
|
|
||
| - Keep generated image prompts stable for map pins/icons during UI refactors; changing prompt keys can break perceived continuity even when paths still resolve. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -27,3 +27,7 @@ Applies to `src/components/**`. | |
| - Keep component prop interfaces and runtime `propTypes` optional/required flags synchronized. | ||
| - For reusable components, export explicit prop types and avoid `any` passthrough props. | ||
| - When a prop accepts external/untrusted objects, type as `unknown` at the boundary and narrow before access. | ||
|
|
||
| ## Recent Findings (2026-04) | ||
|
|
||
| - For categorized action menus, keep a one-to-one mapping between action unions and rendered items to prevent unreachable handlers hiding in lookup maps. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -11,12 +11,13 @@ | |
| import { NoteManager } from './stage/NoteManager' | ||
| import { getGigTimeMs } from '../utils/audioEngine' | ||
| import { withTimeout } from './stage/utils' | ||
| import type { StageControllerOptions } from '../types/components' | ||
| import type { RhythmGameRefState } from '../types/rhythmGame' | ||
|
|
||
| /** | ||
| * Manages Pixi.js stage lifecycle and rendering updates. | ||
| */ | ||
| class PixiStageController extends BaseStageController { | ||
| // Getters and Setters for backward compatibility with existing tests | ||
| get colorMatrix() { | ||
| return this.toxicFilterManager?.colorMatrix ?? null | ||
|
|
@@ -96,14 +97,14 @@ | |
| */ | ||
| _initManagersAndStartLoading() { | ||
| // Initialize Managers and start loading assets in parallel | ||
| this.crowdManager = new CrowdManager(this.app, this.stageContainer) | ||
| const crowdLoad = withTimeout( | ||
| this.crowdManager.loadAssets(), | ||
| 'Crowd Assets' | ||
| ) | ||
|
|
||
| this.laneManager = new LaneManager( | ||
| this.app, | ||
| this.stageContainer, | ||
| this.gameStateRef | ||
| ) | ||
|
|
@@ -113,14 +114,14 @@ | |
| // LaneManager owns the rhythm container. | ||
| const rhythmContainer = this.laneManager.container | ||
|
|
||
| this.effectManager = new EffectManager(this.app, rhythmContainer) | ||
| const effectLoad = withTimeout( | ||
| this.effectManager.loadAssets(), | ||
| 'Effect Assets' | ||
| ) | ||
|
|
||
| this.noteManager = new NoteManager( | ||
| this.app, | ||
| rhythmContainer, | ||
| this.gameStateRef, | ||
| (x: any, y: any, color: any) => | ||
|
|
@@ -150,7 +151,7 @@ | |
| */ | ||
| manualUpdate(deltaMS: number) { | ||
| if (!this.app || this.isDisposed) return | ||
| this.handleTicker({ deltaMS }) | ||
| } | ||
|
|
||
| /** | ||
|
|
@@ -165,18 +166,18 @@ | |
|
|
||
| const state = this.gameStateRef?.current | ||
|
|
||
| if (!state || state.isGameOver) { | ||
| return | ||
| } | ||
|
|
||
| const elapsed = getGigTimeMs() | ||
|
|
||
| this.toxicFilterManager.update(state, elapsed, this.stageContainer) | ||
|
|
||
| this.laneManager.update(state) | ||
| this.crowdManager.update( | ||
| state.combo ?? 0, | ||
| state.isToxicMode ?? false, | ||
| elapsed | ||
| ) | ||
| this.noteManager.update(state, elapsed, this.laneManager.layout) | ||
|
|
@@ -202,7 +203,6 @@ | |
| ) | ||
| } | ||
|
|
||
| /** | ||
| * Disposes Pixi resources and removes the canvas. | ||
| * @returns {void} | ||
|
|
@@ -235,5 +235,6 @@ | |
| * @param {object} params - Controller dependencies. | ||
| * @returns {PixiStageController} Controller instance. | ||
| */ | ||
| export const createPixiStageController = ( | ||
| params: StageControllerOptions<RhythmGameRefState> | ||
| ) => new PixiStageController(params) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -20,3 +20,7 @@ Applies to `src/components/minigames/**`. | |
| - Do not import PIXI into logic-only hooks; scene/frame components should consume prepared logic objects. | ||
| - Completion overlays should use provided completion state instead of recomputing reducer data. | ||
| - Arrival routing is owned by `useArrivalLogic`: components/controllers must dispatch completion results (completion action/event) and let shared arrival routing + scene transition logic run there. | ||
|
|
||
| ## Recent Findings (2026-04) | ||
|
|
||
| - Overworld menu refactors must not alter minigame launch contracts; launch actions should remain routed through scene/hooks, not direct component side effects. | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor: inconsistent German translation for the same shortcut concept.
overworld.shortcuts.muteis"Stumm / Laut"while the existingshortcuts.mute(line 798) in this same file is"Stumm / Ton an"for the same toggle concept. Either is grammatical, but the duplicated pair is semantically equivalent and should read the same to avoid drift between the global shortcuts overlay and the overworld-specific list.🌐 Suggested fix
📝 Committable suggestion
🤖 Prompt for AI Agents