Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add linter practice for C# #451

Closed
wants to merge 2 commits into from
Closed

feat: add linter practice for C# #451

wants to merge 2 commits into from

Conversation

gagandeepp
Copy link

@gagandeepp gagandeepp commented Oct 11, 2020 •
edited
Loading

Description

Add linter practice for c# project. Checking for the following packages:

golang.org/x/lint
github.com/golangci/golangci-lint

Motivation and Context

resolves #451

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have updated the documentation accordingly.
  • I have added new practice to practice list in README.md.
  • I have read the CONTRIBUTING document.
  • I haven't repeated the code. (DRY)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@gagandeepp
Copy link
Author

Which Linter you want to use ??

@gagandeepp gagandeepp mentioned this pull request Oct 11, 2020
Open
@adelkahomolova
Copy link
Contributor

Hi, firstly I'm really sorry for the long delay. I had a crazy week. @gagandeepp
I don't know which linter you should check. I'm not a C# developer and choosing the right one is a part of the task.
I'll also ask you for a renaming pull request since it's not an initial commit and also for fill in the PR template. Thanks :)

@gagandeepp gagandeepp changed the title Initial Commit feat: add linter practice for C# Oct 16, 2020
adelkahomolova
adelkahomolova suggested changes Oct 16, 2020
View reviewed changes
src/practices/C#/CsharpLinterUsedPractice.ts

async evaluate(ctx: PracticeContext): Promise<PracticeEvaluationResult> {
if (ctx.packageInspector) {
if (ctx.packageInspector.hasOneOfPackages(['golang.org/x/lint', 'github.com/golangci/golangci-lint'])) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose the most used C# linter.

@adelkahomolova
Copy link
Contributor

Hi, @gagandeepp , how are you? Is there any progress with this PR? :)

@gagandeepp
Copy link
Author

Hi, @gagandeepp , how are you? Is there any progress with this PR? :)

In C# we used IDE built in code analysis which is available as DLL ,so I am not sure whether this change can be implemented.

@adelkahomolova
Copy link
Contributor

@gagandeepp Look at this article. Some of them should be able to use for this practice. https://medium.com/@michaelparkerdev/linting-c-in-2019-stylecop-sonar-resharper-and-roslyn-73e88af57ebd

@adelkahomolova
Copy link
Contributor

Hi, @gagandeepp , is there any progress? :)

@gagandeepp
Copy link
Author

Hi, @gagandeepp , is there any progress? :)

Sorry I am unable to a make progress on this

@gagandeepp gagandeepp closed this Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adelkahomolova adelkahomolova adelkahomolova requested changes

@Jakub-Vacek Jakub-Vacek Awaiting requested review from Jakub-Vacek Jakub-Vacek is a code owner

@prokopsimek prokopsimek Awaiting requested review from prokopsimek prokopsimek is a code owner

@ryzzaki ryzzaki Awaiting requested review from ryzzaki

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gagandeepp @adelkahomolova