Skip to content
This repository has been archived by the owner on Aug 7, 2024. It is now read-only.

Commit

Permalink
Merge pull request #142 from DVPE-cloud/dvpe-deployment-gloo/new-card…
Browse files Browse the repository at this point in the history
…s-certs

rename certificates and tls-secrets
  • Loading branch information
herrLierb committed Apr 19, 2024
2 parents 4e48a5c + 0a35168 commit 9465da0
Show file tree
Hide file tree
Showing 5 changed files with 8 additions and 5 deletions.
3 changes: 3 additions & 0 deletions charts/dvpe-deployment-gloo/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,9 @@ For the full config (rarely needed) see the [README.md](./README.md).
## Changed
- Decommission of CLCM forces to use a new way to create Certificates via the new CARDS API. Since the CARDS API needs a
different set of parameters, we also have to change our API.
- Names of Certificate Resources changed:
- `Secrets`' names now end with `-crt` instead of `-certificate-by-issuer`.
- `Certificate`'s names don't end with `-certificate-by-issuer` anymore.


## [4.9.2]
Expand Down
2 changes: 1 addition & 1 deletion charts/dvpe-deployment-gloo/Chart.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
apiVersion: v1
appVersion: "1.2"
description: Helm chart for installing microservices as gloo enabled VirtualService definitions. This Chart will be deprecated by the end of the year.
description: Deprecated by Q$/24! Helm chart for installing microservices as gloo enabled VirtualService definitions.
name: dvpe-deployment-gloo
version: 5.0.0
home: https://github.com/dvpe-cloud/dvpe-helm
Expand Down
2 changes: 1 addition & 1 deletion charts/dvpe-deployment-gloo/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

![Version: 5.0.0](https://img.shields.io/badge/Version-5.0.0-informational?style=flat-square)

Helm chart for installing microservices as gloo enabled VirtualService definitions. This Chart will be deprecated by the end of the year.
Deprecated by Q$/24! Helm chart for installing microservices as gloo enabled VirtualService definitions.

## Installation
Installs a Microservice Project as [gloo](https://www.solo.io/products/gloo/) enabled VirtualService.
Expand Down
4 changes: 2 additions & 2 deletions charts/dvpe-deployment-gloo/templates/certificate.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
apiVersion: cert-manager.io/v1
kind: Certificate
metadata:
name: {{$serviceName}}-certificate-by-issuer
name: {{$serviceName}}
namespace: {{ $.Release.Namespace}}
labels:
app.kubernetes.io/name: {{ $serviceName }}
Expand Down Expand Up @@ -47,7 +47,7 @@ spec:
commonName: {{ $firstDomain }}
dnsNames:
{{- $domains }}
secretName: {{ $serviceName }}-private-tls-by-issuer
secretName: {{ $serviceName }}-crt
secretTemplate:
annotations:
{{- with .cardsParameters }}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ spec:
minimumProtocolVersion: {{ .Values.gloo.virtualservice.spec.sslConfig.minimumProtocolVersion }}
secretRef:
{{- if .Values.certificate.useCustomIssuer }}
name: {{$serviceName}}-private-tls-by-issuer
name: {{$serviceName}}-crt
namespace: {{ .Release.Namespace -}}
{{ else if and .Values.gloo.virtualservice.spec.sslConfig.secretRef.name .Values.gloo.virtualservice.spec.sslConfig.secretRef.namespace }}
name: {{ .Values.gloo.virtualservice.spec.sslConfig.secretRef.name }}
Expand Down

0 comments on commit 9465da0

Please sign in to comment.