Skip to content

Fix crash on invalid host header #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 5 commits into
base: develop
Choose a base branch
from
Draft

Fix crash on invalid host header #61

wants to merge 5 commits into from

Conversation

frereit
Copy link
Member

@frereit frereit commented Apr 5, 2022 •
edited
Loading

This also now respects X-Forwarded-Host headers for the CTF urls.

@frereit frereit marked this pull request as draft April 25, 2022 14:23
@frereit
Copy link
Member Author

frereit commented Apr 25, 2022 •
edited
Loading

This is still (kind-of) blocked by #75 , same issue as in TFNS#146

I will cherry-pick the host-header fix because it's a critical bug (as it can be abused to crash the API container) and open a new PR later or tomorrow.

@frereit frereit linked an issue Apr 25, 2022 that may be closed by this pull request
broken link in add-ical-url #75
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JM-Lemmi JM-Lemmi JM-Lemmi approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

broken link in add-ical-url

2 participants

@frereit @JM-Lemmi