misc fixes: ip6 #174
Merged
misc fixes: ip6 #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
christophefontaine
commented
Mar 4, 2025
•
christophefontaine
commented
- Simple fix on interface creation.
- Cleanup ip6 rib when an IPv6 address is deleted
When an interface was created with a wrong configuration, such as: $ add interface port p1 devargs net_tap1,iface=p1 mac f0:0d:ac:dc:00:01 rxqs 2 The interface isn't created and the graph is destroyed. As the stats pointer is NULL, and rte_graph_cluster_stats_destroy doesn't validate its input, Grout crashes. Signed-off-by: Christophe Fontaine <[email protected]>
christophefontaine
changed the title
rjarry
requested changes
Mar 4, 2025
christophefontaine
force-pushed
the
fix_crash
branch
from
6a80370 to
f67009e
Compare
christophefontaine
force-pushed
the
fix_crash
branch
from
f67009e to
e7d58d5
Compare
rjarry
requested changes
Mar 4, 2025
modules/ip6/control/route.c
Outdated
| rib6_delete(nh->vrf_id, nh->iface_id, &nh->ipv6, RTE_IPV6_MAX_DEPTH); | ||
| rib6_delete(nh->vrf_id, nh->iface_id, &nh->ipv6, nh->prefixlen); |
There was a problem hiding this comment.
I have a feeling that we should keep this at the beginning:
rib6_delete(nh->vrf_id, nh->iface_id, &nh->ipv6, RTE_IPV6_MAX_DEPTH);And only call the second one if nh->prefixlen != 0 (i.e. it is a local interface address). Gateway nexthops do not have their prefixlen set to anything:
if (nh->prefixlen != 0)
rib6_delete(nh->vrf_id, nh->iface_id, &nh->ipv6, nh->prefixlen);There was a problem hiding this comment.
Yes, that's why I didn't want to merge this immediately (even if I need it !) that I put this PR in draft first.
If the gateway NH has not prefix len set, shouldn't we instead set it to RTE_IPv6_MAX_DEPTH / RTE_IPv4_MAX_DEPTH ?
We couldn't add a previously added IPv6 on an interface, either through the command line, or for link local ip when we add/delete/add an interface. In rib6_cleanup, call rib6_delete with the prefixlen instead of the max prefix. Add these checks in the existing test. Signed-off-by: Christophe Fontaine <[email protected]>
Similar to ipv6 nexthop suppression, check the NH flags to delete either with embedded prefix len or the max prefix len (/32). Update test to ensure we can add/del/add the same address. Signed-off-by: Christophe Fontaine <[email protected]>
christophefontaine
force-pushed
the
fix_crash
branch
from
e7d58d5 to
d87170b
Compare
rjarry
approved these changes
Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.