Icmp fixes #173
Merged
Icmp fixes #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename the id field of gr_ip*_icmp_* API messages to ident to avoid any ambiguity. Signed-off-by: Robin Jarry <[email protected]>
The GR_IP6_ICMP6_SEND message does not return any response payload. Remove the unused allocation. Signed-off-by: Robin Jarry <[email protected]>
When used without a seed, random() will be initialized with a seed value of 1 which will in turn always return the same sequence of numbers. Initialize the random seed with the current boot time in micro seconds. Signed-off-by: Robin Jarry <[email protected]>
Always require the clients to provide an ICMP identifier AND sequence number like in the IPv6 implementation. Signed-off-by: Robin Jarry <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.