Skip to content

Commit

Permalink
net/idpf: re-enable unused variable warnings
Browse files Browse the repository at this point in the history
The idpf driver was being built with warnings disabled for unused
variables. However, while the warning was being disabled in the base
code directory, all suppressed warnings were in the main directory.
Therefore, just remove the unused variables and re-enable the
warnings.

Signed-off-by: Bruce Richardson <[email protected]>
Acked-by: Praveen Shetty <[email protected]>
  • Loading branch information
bruce-richardson committed Feb 11, 2025
1 parent 6fd03e7 commit efe7bfd
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 13 deletions.
9 changes: 0 additions & 9 deletions drivers/net/intel/idpf/base/meson.build
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,3 @@ sources += files(
'idpf_controlq.c',
'idpf_controlq_setup.c',
)

error_cflags = [
'-Wno-unused-variable',
]
foreach flag: error_cflags
if cc.has_argument(flag)
cflags += flag
endif
endforeach
2 changes: 0 additions & 2 deletions drivers/net/intel/idpf/idpf_common_rxtx.c
Original file line number Diff line number Diff line change
Expand Up @@ -1178,7 +1178,6 @@ idpf_dp_singleq_recv_scatter_pkts(void *rx_queue, struct rte_mbuf **rx_pkts,
struct rte_mbuf *last_seg = rxq->pkt_last_seg;
struct rte_mbuf *rxm;
struct rte_mbuf *nmb;
struct rte_eth_dev *dev;
const uint32_t *ptype_tbl = rxq->adapter->ptype_tbl;
uint16_t rx_id = rxq->rx_tail;
uint16_t rx_packet_len;
Expand Down Expand Up @@ -1310,7 +1309,6 @@ idpf_xmit_cleanup(struct idpf_tx_queue *txq)
uint16_t nb_tx_desc = txq->nb_tx_desc;
uint16_t desc_to_clean_to;
uint16_t nb_tx_to_clean;
uint16_t i;

volatile struct idpf_base_tx_desc *txd = txq->tx_ring;

Expand Down
4 changes: 2 additions & 2 deletions drivers/net/intel/idpf/idpf_common_virtchnl.c
Original file line number Diff line number Diff line change
Expand Up @@ -362,7 +362,7 @@ idpf_vc_queue_grps_add(struct idpf_vport *vport,
{
struct idpf_adapter *adapter = vport->adapter;
struct idpf_cmd_info args;
int size, qg_info_size;
int size;
int err = -1;

size = sizeof(*p2p_queue_grps_info) +
Expand Down Expand Up @@ -1044,7 +1044,7 @@ int idpf_vc_rxq_config_by_info(struct idpf_vport *vport, struct virtchnl2_rxq_in
struct idpf_adapter *adapter = vport->adapter;
struct virtchnl2_config_rx_queues *vc_rxqs = NULL;
struct idpf_cmd_info args;
int size, err, i;
int size, err;

size = sizeof(*vc_rxqs) + (num_qs - 1) *
sizeof(struct virtchnl2_rxq_info);
Expand Down

0 comments on commit efe7bfd

Please sign in to comment.