net/mlx5: fix leak in HWS flow counter action

This was caught by our internal covscan. mp_name can be leaked in case of errors. Fixes: 4d368e1 ("net/mlx5: support flow counter action for HWS") Cc: [email protected] Signed-off-by: David Marchand <[email protected]>
DPDK · Feb 10, 2025 · 98f7f1e · 98f7f1e
1 parent 6c08078
commit 98f7f1e
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/drivers/net/mlx5/mlx5_hws_cnt.c b/drivers/net/mlx5/mlx5_hws_cnt.c
@@ -723,7 +723,7 @@ mlx5_hws_cnt_pool_create(struct rte_eth_dev *dev,
 	if (priv->sh->cnt_svc == NULL) {
 		ret = mlx5_hws_cnt_svc_init(priv->sh, error);
 		if (ret)
-			return ret;
+			goto error;
 	}
 	cparam.fetch_sz = HWS_CNT_CACHE_FETCH_DEFAULT;
 	cparam.preload_sz = HWS_CNT_CACHE_PRELOAD_DEFAULT;
@@ -767,6 +767,7 @@ mlx5_hws_cnt_pool_create(struct rte_eth_dev *dev,
 	MLX5_ASSERT(ret);
 	mlx5_hws_cnt_pool_destroy(priv->sh, cpool);
 	priv->hws_cpool = NULL;
+	mlx5_free(mp_name);
 	return ret;
 }